Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 61493002: Linux: Verify checksums when downloading Debian Packages.bz2 files in the sysroot script. (Closed)

Created:
7 years, 1 month ago by Lei Zhang
Modified:
7 years, 1 month ago
Reviewers:
Michael Moss, Sam Clegg
CC:
chromium-reviews, grt+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

Linux: Verify checksums when downloading Debian Packages.bz2 files in the sysroot script. BUG=314766 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233546

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -2 lines) Patch
M chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh View 1 4 chunks +68 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
7 years, 1 month ago (2013-11-06 04:13:45 UTC) #1
Sam Clegg
Shouldn't these be some kind of verification step during the actual downloading and building of ...
7 years, 1 month ago (2013-11-06 18:14:00 UTC) #2
Lei Zhang
On 2013/11/06 18:14:00, Sam Clegg wrote: > Shouldn't these be some kind of verification step ...
7 years, 1 month ago (2013-11-06 18:21:19 UTC) #3
Sam Clegg
lgtm
7 years, 1 month ago (2013-11-06 18:25:12 UTC) #4
Michael Moss
lgtm https://codereview.chromium.org/61493002/diff/1/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh File chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh (right): https://codereview.chromium.org/61493002/diff/1/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh#newcode473 chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh:473: --keyring /etc/apt/trusted.gpg.d/debian-archive-wheezy-stable.gpg \ Where do these keyrings come ...
7 years, 1 month ago (2013-11-06 18:32:45 UTC) #5
Lei Zhang
On 2013/11/06 18:32:45, Michael Moss wrote: > lgtm > > https://codereview.chromium.org/61493002/diff/1/chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh > File chrome/installer/linux/sysroot_scripts/sysroot-creator-debian.wheezy.sh > ...
7 years, 1 month ago (2013-11-06 18:55:09 UTC) #6
Lei Zhang
On 2013/11/06 18:55:09, Lei Zhang wrote: > On 2013/11/06 18:32:45, Michael Moss wrote: > > ...
7 years, 1 month ago (2013-11-06 19:58:45 UTC) #7
Michael Moss
lgtm
7 years, 1 month ago (2013-11-06 19:59:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/61493002/100001
7 years, 1 month ago (2013-11-06 20:09:13 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 08:16:28 UTC) #10
Message was sent while issue was closed.
Change committed as 233546

Powered by Google App Engine
This is Rietveld 408576698