Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 614903003: Instrumented libraries: introduce release-specific patches. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: introduce release-specific patches. This CL enables applying different custom patches depending on the Ubuntu release (Precise/Trusty). It also adds two Trusty-specific patches. BUG=414189 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/da840b61c8e9c7f1c4e55ebb83eefeefb24c19d9 Cr-Commit-Position: refs/heads/master@{#297672}

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -44 lines) Patch
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 3 chunks +16 lines, -2 lines 0 comments Download
D third_party/instrumented_libraries/patches/libfontconfig.diff View 1 chunk +0 lines, -13 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libfontconfig.precise.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libfontconfig.trusty.diff View 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/instrumented_libraries/patches/libgtk2.0-0.diff View 1 chunk +0 lines, -26 lines 0 comments Download
A + third_party/instrumented_libraries/patches/libgtk2.0-0.precise.diff View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/instrumented_libraries/patches/libgtk2.0-0.trusty.diff View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
earthdok
please take a look
6 years, 2 months ago (2014-09-30 20:33:01 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/614903003/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/614903003/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp#newcode225 third_party/instrumented_libraries/instrumented_libraries.gyp:225: ['"<(_ubuntu_release)"=="precise"', { Can you please reduce it to: 'patch': ...
6 years, 2 months ago (2014-10-01 08:55:49 UTC) #3
earthdok
https://codereview.chromium.org/614903003/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/614903003/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp#newcode225 third_party/instrumented_libraries/instrumented_libraries.gyp:225: ['"<(_ubuntu_release)"=="precise"', { On 2014/10/01 08:55:49, Alexander Potapenko wrote: > ...
6 years, 2 months ago (2014-10-01 13:20:00 UTC) #4
Alexander Potapenko
LGTM
6 years, 2 months ago (2014-10-01 13:22:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614903003/20001
6 years, 2 months ago (2014-10-01 17:42:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a94ca8e4932809c6f0a62110de13228db0aa2941
6 years, 2 months ago (2014-10-01 17:44:01 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 17:44:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/da840b61c8e9c7f1c4e55ebb83eefeefb24c19d9
Cr-Commit-Position: refs/heads/master@{#297672}

Powered by Google App Engine
This is Rietveld 408576698