ui/base/resource/data_pack_unittest.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/resource/data_pack_unittest.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/resource/data_pack_unittest.cc

diff --git a/ui/base/resource/data_pack_unittest.cc b/ui/base/resource/data_pack_unittest.cc

index 8a88e0297c1f600ce210e8464b66cc251f4e44e0..4ab4faa1bb00da32fc7e1156b64d433b1ba14e63 100644

--- a/ui/base/resource/data_pack_unittest.cc

+++ b/ui/base/resource/data_pack_unittest.cc

@@ -102,8 +102,8 @@ TEST(DataPackTest, LoadFromFileRegion) {

const char kPadding[5678] = {0};

ASSERT_EQ(static_cast<int>(sizeof(kPadding)),

base::WriteFile(data_path, kPadding, sizeof(kPadding)));

- ASSERT_EQ(static_cast<int>(kSamplePakSize),

- base::AppendToFile(data_path, kSamplePakContents, kSamplePakSize));

+ ASSERT_TRUE(base::AppendToFile(

+ data_path, kSamplePakContents, kSamplePakSize));

base::File file(data_path, base::File::FLAG_OPEN | base::File::FLAG_READ);

ASSERT_TRUE(file.IsValid());

« no previous file with comments | « third_party/zlib/google/zip_reader.cc ('k') | no next file » | no next file with comments »