chromeos/process_proxy/process_proxy.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/process_proxy/process_proxy.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/process_proxy/process_proxy.cc

diff --git a/chromeos/process_proxy/process_proxy.cc b/chromeos/process_proxy/process_proxy.cc

index 881ea5abdfd276fdb603d61ac3781ce7e78d7b4c..b1021f4eeefd322e531fc78c273ee3f8e89b718f 100644

--- a/chromeos/process_proxy/process_proxy.cc

+++ b/chromeos/process_proxy/process_proxy.cc

@@ -160,10 +160,8 @@ bool ProcessProxy::Write(const std::string& text) {

// We don't want to write '\0' to the pipe.

size_t data_size = text.length() * sizeof(*text.c_str());

- int bytes_written =

- base::WriteFileDescriptor(pt_pair_[PT_MASTER_FD],

- text.c_str(), data_size);

- return (bytes_written == static_cast<int>(data_size));

+ return base::WriteFileDescriptor(

+ pt_pair_[PT_MASTER_FD], text.c_str(), data_size);

}

bool ProcessProxy::OnTerminalResize(int width, int height) {