base/files/file_util_unittest.cc - Issue 614893004: Refactor AppendToFile and WriteFileDescriptor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_util_unittest.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_util_unittest.cc

diff --git a/base/files/file_util_unittest.cc b/base/files/file_util_unittest.cc

index 47dec303f8e33d598203e2b0b1b774c9acf8854e..38fe868df3fab256012a29a802e10f8c4f90a1dc 100644

--- a/base/files/file_util_unittest.cc

+++ b/base/files/file_util_unittest.cc

@@ -1977,11 +1977,10 @@ TEST_F(FileUtilTest, AppendToFile) {

FilePath foobar(data_dir.Append(FILE_PATH_LITERAL("foobar.txt")));

std::string data("hello");

- EXPECT_EQ(-1, AppendToFile(foobar, data.c_str(), data.length()));

+ EXPECT_FALSE(AppendToFile(foobar, data.c_str(), data.size()));

EXPECT_EQ(static_cast<int>(data.length()),

WriteFile(foobar, data.c_str(), data.length()));

- EXPECT_EQ(static_cast<int>(data.length()),

- AppendToFile(foobar, data.c_str(), data.length()));

+ EXPECT_TRUE(AppendToFile(foobar, data.c_str(), data.size()));

const std::wstring read_content = ReadTextFile(foobar);

EXPECT_EQ(L"hellohello", read_content);

« no previous file with comments | « base/files/file_util_posix.cc ('k') | base/files/file_util_win.cc » ('j') | no next file with comments »