Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6658)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/test/trace_to_file.cc

Issue 614893004: Refactor AppendToFile and WriteFileDescriptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/files/file_util_win.cc ('K') | « base/sync_socket_posix.cc ('k') | chrome/browser/devtools/devtools_file_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_to_file.cc
diff --git a/base/test/trace_to_file.cc b/base/test/trace_to_file.cc
index 6caaf47af32bbf3feedd17bce2a1e5af9272d500..423f65c125dc610717a0ccf293aa5e5343aea213 100644
--- a/base/test/trace_to_file.cc
+++ b/base/test/trace_to_file.cc
@@ -67,8 +67,8 @@ void TraceToFile::AppendFileFooter() {
}
void TraceToFile::TraceOutputCallback(const std::string& data) {
- int ret = AppendToFile(path_, data.c_str(), static_cast<int>(data.size()));
- DCHECK_NE(-1, ret);
+ bool ret = AppendToFile(path_, data.c_str(), static_cast<int>(data.size()));
+ DCHECK(ret);
}
static void OnTraceDataCollected(
« base/files/file_util_win.cc ('K') | « base/sync_socket_posix.cc ('k') | chrome/browser/devtools/devtools_file_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698