Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 614893002: use base::Time constants in mojo instead of defining locally (Closed)

Created:
6 years, 2 months ago by prashant.hiremath
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

use base::Time constants in mojo instead of defining locally BUG=412254 Committed: https://crrev.com/75b0eb8eb60d9d8d736a89c3e63c3163089ee8a8 Cr-Commit-Position: refs/heads/master@{#299088}

Patch Set 1 #

Total comments: 2

Patch Set 2 : reformated for 80 char in length #

Total comments: 1

Patch Set 3 : changed as per review comment #

Total comments: 1

Patch Set 4 : indented properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/apps/js/bindings/monotonic_clock.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
prashant.hiremath
Please Review
6 years, 2 months ago (2014-09-30 08:15:53 UTC) #2
prashant.hiremath
Gentle ping.
6 years, 2 months ago (2014-10-09 15:04:18 UTC) #3
darin (slow to review)
https://codereview.chromium.org/614893002/diff/1/mojo/apps/js/bindings/monotonic_clock.cc File mojo/apps/js/bindings/monotonic_clock.cc (right): https://codereview.chromium.org/614893002/diff/1/mojo/apps/js/bindings/monotonic_clock.cc#newcode21 mojo/apps/js/bindings/monotonic_clock.cc:21: return static_cast<double>(mojo::GetTimeTicksNow()) / base::Time::kMicrosecondsPerSecond; nit: need to reformat for ...
6 years, 2 months ago (2014-10-09 17:12:50 UTC) #5
prashant.hiremath
https://codereview.chromium.org/614893002/diff/1/mojo/apps/js/bindings/monotonic_clock.cc File mojo/apps/js/bindings/monotonic_clock.cc (right): https://codereview.chromium.org/614893002/diff/1/mojo/apps/js/bindings/monotonic_clock.cc#newcode21 mojo/apps/js/bindings/monotonic_clock.cc:21: return static_cast<double>(mojo::GetTimeTicksNow()) / base::Time::kMicrosecondsPerSecond; On 2014/10/09 17:12:50, darin wrote: ...
6 years, 2 months ago (2014-10-09 17:44:40 UTC) #6
prashant.hiremath
PTAL
6 years, 2 months ago (2014-10-10 02:29:12 UTC) #7
qsr
https://codereview.chromium.org/614893002/diff/50001/mojo/apps/js/bindings/monotonic_clock.cc File mojo/apps/js/bindings/monotonic_clock.cc (right): https://codereview.chromium.org/614893002/diff/50001/mojo/apps/js/bindings/monotonic_clock.cc#newcode22 mojo/apps/js/bindings/monotonic_clock.cc:22: base::Time::kMicrosecondsPerSecond; continuation should indent by 4 characters.
6 years, 2 months ago (2014-10-10 09:02:11 UTC) #9
prashant.hiremath
PTAL
6 years, 2 months ago (2014-10-10 09:22:37 UTC) #10
qsr
https://codereview.chromium.org/614893002/diff/110001/mojo/apps/js/bindings/monotonic_clock.cc File mojo/apps/js/bindings/monotonic_clock.cc (right): https://codereview.chromium.org/614893002/diff/110001/mojo/apps/js/bindings/monotonic_clock.cc#newcode22 mojo/apps/js/bindings/monotonic_clock.cc:22: base::Time::kMicrosecondsPerSecond; Sorry, what I meant was 4 characters more ...
6 years, 2 months ago (2014-10-10 09:29:33 UTC) #11
prashant.hiremath
indented as per review comment
6 years, 2 months ago (2014-10-10 09:37:50 UTC) #12
qsr
lgtm
6 years, 2 months ago (2014-10-10 10:11:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614893002/150001
6 years, 2 months ago (2014-10-10 10:29:15 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:150001)
6 years, 2 months ago (2014-10-10 11:07:30 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 11:08:12 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/75b0eb8eb60d9d8d736a89c3e63c3163089ee8a8
Cr-Commit-Position: refs/heads/master@{#299088}

Powered by Google App Engine
This is Rietveld 408576698