Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issue 614863002: Added test case for CopyImageUrl and CopyEmailAddress. (Closed)

Created:
6 years, 2 months ago by ankit
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer, Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added test case for CopyImageUrl and CopyEmailAddress. Test case was missing for copyImageUrl and CopyEmailAddress options newly added in context menu. Added test case for same. BUG=418073 Committed: https://crrev.com/524325fd4502e6394a9ec73fb8d15316df89f04b Cr-Commit-Position: refs/heads/master@{#298015}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Incorporated review comments. #

Patch Set 3 : Replaced LargeTest with MediumTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 1 2 11 chunks +34 lines, -9 lines 0 comments Download
M chrome/test/data/android/contextmenu/context_menu_test.html View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
ankit
@Bernhard PTAL
6 years, 2 months ago (2014-09-30 06:07:31 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/614863002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java (right): https://codereview.chromium.org/614863002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java#newcode213 chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:213: @MediumTest Why are these tests medium if e.g. testCopyLinkTextSimple() ...
6 years, 2 months ago (2014-09-30 08:51:08 UTC) #3
ankit
@Bernhard PTAL new patch and comments. https://codereview.chromium.org/614863002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java (right): https://codereview.chromium.org/614863002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java#newcode213 chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:213: @MediumTest On 2014/09/30 ...
6 years, 2 months ago (2014-09-30 09:20:46 UTC) #4
Bernhard Bauer
https://codereview.chromium.org/614863002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java (right): https://codereview.chromium.org/614863002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java#newcode213 chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:213: @MediumTest On 2014/09/30 09:20:46, ankit wrote: > On 2014/09/30 ...
6 years, 2 months ago (2014-09-30 10:05:25 UTC) #5
ankit
@Bernhard PTAL I have replaced @LargeTest with @MediumTest
6 years, 2 months ago (2014-09-30 11:50:16 UTC) #6
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-09-30 12:52:51 UTC) #7
ankit
On 2014/09/30 12:52:51, Bernhard Bauer wrote: > lgtm @Bernhard Thanks. @Ted PTAL
6 years, 2 months ago (2014-09-30 13:09:43 UTC) #8
Ted C
lgtm
6 years, 2 months ago (2014-10-01 23:45:51 UTC) #9
ankit
On 2014/10/01 23:45:51, Ted C wrote: > lgtm @Ted Thanks.
6 years, 2 months ago (2014-10-03 07:30:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614863002/40001
6 years, 2 months ago (2014-10-03 07:31:19 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 7113aaa6bb792bf89b9f910b4002dba44fec5175
6 years, 2 months ago (2014-10-03 08:44:11 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 08:44:50 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/524325fd4502e6394a9ec73fb8d15316df89f04b
Cr-Commit-Position: refs/heads/master@{#298015}

Powered by Google App Engine
This is Rietveld 408576698