sandbox/win/src/handle_policy.cc - Issue 614813002: Cleanup sandbox/ in advance of re-enabling some MSVC warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/handle_policy.cc

Issue 614813002: Cleanup sandbox/ in advance of re-enabling some MSVC warnings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/handle_policy.cc

diff --git a/sandbox/win/src/handle_policy.cc b/sandbox/win/src/handle_policy.cc

index f5f1c273b969be0dc8fe207ce3765b7151ecf694..1023030792741636ef34d7c30e78c82a0a26082d 100644

--- a/sandbox/win/src/handle_policy.cc

+++ b/sandbox/win/src/handle_policy.cc

@@ -79,7 +79,6 @@ DWORD HandlePolicy::DuplicateHandleProxyAction(EvalResult eval_result,

// (this process) is the valid target.

HANDLE target_process = remote_target_process.IsValid() ?

remote_target_process.Get() : ::GetCurrentProcess();

- DWORD result = ERROR_SUCCESS;

if (!::DuplicateHandle(::GetCurrentProcess(), source_handle, target_process,

target_handle, desired_access, FALSE,

options)) {

« no previous file with comments | « sandbox/win/src/handle_closer_test.cc ('k') | sandbox/win/src/policy_opcodes_unittest.cc » ('j') | no next file with comments »