Cleanup sandbox/ in advance of re-enabling some MSVC warnings.

sandbox/win/src/policy_opcodes_unittest.cc

Index: sandbox/win/src/policy_opcodes_unittest.cc
diff --git a/sandbox/win/src/policy_opcodes_unittest.cc b/sandbox/win/src/policy_opcodes_unittest.cc
index c69aad8c84e83e56db718100e0dbf53972c05424..e413a43492f813409b0dd40e45ce344c6933a5b2 100644
--- a/sandbox/win/src/policy_opcodes_unittest.cc
+++ b/sandbox/win/src/policy_opcodes_unittest.cc
@@ -289,7 +289,8 @@ TEST(PolicyEngineTest, WCharOpcodes1) {
 
   // Test that we function if the string does not fit. In this case we
   // try to match 'the lazy dog' against 'he lazy dog'.
-  PolicyOpcode* op6 = opcode_maker.MakeOpWStringMatch(0, txt4, 2,
+  // !!! Are we supposed to Evaluate() this opcode and test the result?

[Peter Kasting, 2014/09/29 23:09:25]

This question needs answering before this CL can be committed.

[cpu_(ooo_6.6-7.5), 2014/09/30 17:57:26]

Yes, looks like somebody forgot to call evaluate() and check the result.

I assume line 295 will move above, to 289

[Peter Kasting, 2014/10/01 02:32:13]

Fixed.
Sure, assuming we intend to test that if Evaluate() fails, it won't change the
provided value.  I added a few other such checks in here as well.

+  /*PolicyOpcode* op6 =*/ opcode_maker.MakeOpWStringMatch(0, txt4, 2,
                                                       CASE_SENSITIVE, kPolNone);
   EXPECT_EQ(24, mc1.position);