Test IsSettingsBrowser in BrowserShortcutLauncherItemController

Test IsSettingsBrowser in BrowserShortcutLauncherItemController

This is a simpler fix than https://codereview.chromium.org/595213005/.
I would like to make a more robust fix (and added a TODO), but this
should address the crash bug for 38 and 39 while allowing us to
investigate a better solution for 40.

BUG=417633
Committed: https://crrev.com/70af9b5824f54061e6b02ce5e5809ae177b65287
Cr-Commit-Position: refs/heads/master@{#297327}

[stevenjb, 2014-09-29 22:04:13]

stevenjb@chromium.org changed reviewers:
+ skuhne@chromium.org, sky@chromium.org

[stevenjb, 2014-09-29 22:04:13]

Simpler crash fix for 38/39.

[Mr4D (OOO till 08-26), 2014-09-29 23:26:25]

Much better! lgtm

[sky, 2014-09-29 23:53:43]

LGTM

[stevenjb, 2014-09-30 00:02:32]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-30 00:03:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/614793003/1

[commit-bot: I haz the power, 2014-09-30 01:12:33]

Committed patchset #1 (id:1) as 5818b2a5f6360deb47c541e5ecac9982120b81a3

[commit-bot: I haz the power, 2014-09-30 01:13:15]

Patchset 1 (id:??) landed as
https://crrev.com/70af9b5824f54061e6b02ce5e5809ae177b65287
Cr-Commit-Position: refs/heads/master@{#297327}