Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Issue 614773003: Revert of GetUILanguageList should correctly handle locale aliases. (Closed)

Created:
6 years, 2 months ago by Nikita (slow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of GetUILanguageList should correctly handle locale aliases. (patchset #2 id:20001 of https://codereview.chromium.org/608903003/) Reason for revert: 22366:22366:0929/155200:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fffeb18b02e base::debug::StackTrace::StackTrace() #1 0x7fffeb216e02 logging::LogMessage::~LogMessage() #2 0x7fffeb309b9f base::ThreadRestrictions::AssertIOAllowed() #3 0x7fffeb1fef31 base::PathExists() #4 0x7fffebbf5837 ui::ResourceBundle::GetLocaleFilePath() #5 0x7fffebbf5689 ui::ResourceBundle::LocaleDataPakExists() #6 0x7fffebbc770a (anonymous namespace)::IsLocaleAvailable() #7 0x7fffebbc723c l10n_util::CheckAndResolveLocale() #8 0x55555782fe45 chromeos::(anonymous namespace)::GetLanguageList() #9 0x55555782f0d5 chromeos::GetUILanguageList() #10 0x55555783d07f chromeos::NetworkScreenHandler::GetAdditionalParameters() #11 0x55555783d74f chromeos::NetworkScreenHandler::GetAdditionalParameters() #12 0x55555780d38d chromeos::BaseScreenHandler::GetLocalizedStrings() #13 0x555557430d0c chromeos::OobeUI::GetLocalizedStrings() #14 0x55555743035d chromeos::OobeUI::OobeUI() #15 0x555557464d13 (anonymous namespace)::NewWebUI<>() #16 0x55555746318f ChromeWebUIControllerFactory::CreateWebUIControllerForURL() #17 0x7ffff3bb04c7 content::WebUIControllerFactoryRegistry::CreateWebUIControllerForURL() #18 0x7ffff3b58acb content::WebContentsImpl::CreateWebUI() #19 0x7ffff3b681c2 content::WebContentsImpl::CreateWebUIForRenderManager() #20 0x7ffff3b681ff content::WebContentsImpl::CreateWebUIForRenderManager() #21 0x7ffff3517724 content::RenderFrameHostManager::SetPendingWebUI() #22 0x7ffff35180dc content::RenderFrameHostManager::UpdateStateForNavigate() #23 0x7ffff3517952 content::RenderFrameHostManager::Navigate() #24 0x7ffff34f7715 content::NavigatorImpl::NavigateToEntry() #25 0x7ffff34f7cce content::NavigatorImpl::NavigateToPendingEntry() #26 0x7ffff3b5ef21 content::WebContentsImpl::NavigateToPendingEntry() #27 0x7ffff3b5ef52 content::WebContentsImpl::NavigateToPendingEntry() #28 0x7ffff34dd7b5 content::NavigationControllerImpl::NavigateToPendingEntry() #29 0x7ffff34ddbda content::NavigationControllerImpl::LoadEntry() #30 0x7ffff34df6c4 content::NavigationControllerImpl::LoadURLWithParams() #31 0x7ffff34dee3f content::NavigationControllerImpl::LoadURL() #32 0x7ffff2b051ee views::WebView::LoadInitialURL() #33 0x55555813ce7b chromeos::WebUILoginView::LoadURL() #34 0x555558126f0f chromeos::LoginDisplayHostImpl::LoadURL() #35 0x555558126b25 chromeos::LoginDisplayHostImpl::StartWizard() #36 0x5555581292da chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #37 0x555558128a18 chromeos::LoginDisplayHostImpl::Observe() #38 0x55555812940d chromeos::LoginDisplayHostImpl::Observe() #39 0x7ffff37da39b content::NotificationServiceImpl::Notify() #40 0x555557f3a994 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #41 0x7fffea807a07 ash::RootWindowController::OnWallpaperAnimationFinished() #42 0x7fffea75802a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #43 0x7fffeae72e40 ui::ImplicitAnimationObserver::CheckCompleted() #44 0x7fffeae72de5 ui::ImplicitAnimationObserver::SetActive() #45 0x7fffeae937b5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #46 0x7fffea757bb4 ash::DesktopBackgroundWidgetController::StartAnimating() #47 0x7fffea74e2c6 ash::DesktopBackgroundController::InstallDesktopController() #48 0x7fffea74e3b3 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #49 0x7fffea74db8c ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #50 0x7fffea74d854 ash::DesktopBackgroundController::SetWallpaperImage() #51 0x55555816ad4e chromeos::WallpaperManager::DoSetDefaultWallpaper() #52 0x55555816a26d chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #53 0x555558188f12 base::internal::RunnableAdapter<>::Run() #54 0x555558188e89 base::internal::InvokeHelper<>::MakeItSo() #55 0x555558188e45 base::internal::Invoker<>::Run() #56 0x7fffeb17303e base::Callback<>::Run() #57 0x7fffeb3100d6 base::Timer::RunScheduledTask() #58 0x7fffeb3101ec base::BaseTimerTaskInternal::Run() #59 0x7fffeb3104b2 base::internal::RunnableAdapter<>::Run() #60 0x7fffeb31041c base::internal::InvokeHelper<>::MakeItSo() #61 0x7fffeb3103c5 base::internal::Invoker<>::Run() Original issue's description: > GetUILanguageList should correctly handle locale aliases. > > GetUILanguageList didn't check for locale aliases when resolving input > method languages. This patch fixes it. > > BUG=418220 > TEST=manual > > Committed: https://crrev.com/b1c6a6e8fc6b4368cf63dfc00e8a4fec691fed1d > Cr-Commit-Position: refs/heads/master@{#297086} TBR=dzhioev@chromium.org,alemate@chromium.org NOTREECHECKS=true NOTRY=true BUG=418220 Committed: https://crrev.com/38da55efc7c6150f0ff9929297c6da77944679e5 Cr-Commit-Position: refs/heads/master@{#297253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikita (slow)
Created Revert of GetUILanguageList should correctly handle locale aliases.
6 years, 2 months ago (2014-09-29 20:48:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614773003/1
6 years, 2 months ago (2014-09-29 20:50:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 832475a747247144effd8954b05dd2d9f196fe58
6 years, 2 months ago (2014-09-29 20:51:26 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 20:52:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38da55efc7c6150f0ff9929297c6da77944679e5
Cr-Commit-Position: refs/heads/master@{#297253}

Powered by Google App Engine
This is Rietveld 408576698