Issue 614753002: allow caller to override the default output directory for gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 614753002: allow caller to override the default output directory for gyp (Closed)

Created:
6 years, 2 months ago by humper

Modified:
6 years, 2 months ago

Reviewers:
jcgregorio

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

allow caller to override the default output directory for gyp BUG=skia: Committed: https://skia.googlesource.com/skia/+/4572ae9221a2bef60a2867682b738715a431f3a6

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	gyp_skia	View		2 chunks	+5 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

humper

ptal -- this is useful for staging the output Release/ directory for webtry

6 years, 2 months ago (2014-09-29 17:56:23 UTC) #2

jcgregorio

On 2014/09/29 17:56:23, humper wrote: > ptal -- this is useful for staging the output ...

6 years, 2 months ago (2014-09-29 17:58:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614753002/1

6 years, 2 months ago (2014-09-29 18:35:33 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 18:42:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 4572ae9221a2bef60a2867682b738715a431f3a6