Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: test/mjsunit/array-reduce.js

Issue 614733002: Array.prototype.{reduce, reduceRight}: Wrong order of operations when determining initial value. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove unnneded check (length is zero and 'current' is not defined). Fixed tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/array.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 return a + b; 514 return a + b;
515 } 515 }
516 516
517 var arr = [1, 2, 3, 4]; 517 var arr = [1, 2, 3, 4];
518 testReduce("reduce", "ArrayManipulationExtender", 10, 518 testReduce("reduce", "ArrayManipulationExtender", 10,
519 [[0, 1, 0, [1, 2, 3, 4], 1], 519 [[0, 1, 0, [1, 2, 3, 4], 1],
520 [1, 2, 1, [1, 2, 3, 4, 4], 3], 520 [1, 2, 1, [1, 2, 3, 4, 4], 3],
521 [3, 3, 2, [1, 2, 3, 4, 4, 5], 6], 521 [3, 3, 2, [1, 2, 3, 4, 4, 5], 6],
522 [6, 4, 3, [1, 2, 3, 4, 4, 5, 6], 10], 522 [6, 4, 3, [1, 2, 3, 4, 4, 5, 6], 10],
523 ], arr, extender, 0); 523 ], arr, extender, 0);
524
525 var arr = [];
526 Object.defineProperty(arr, "0", { get: function() { delete this[0] },
527 configurable: true });
528 assertEquals(undefined, arr.reduce(function(val) { return val }));
529
530 var arr = [];
531 Object.defineProperty(arr, "0", { get: function() { delete this[0] },
532 configurable: true});
533 assertEquals(undefined, arr.reduceRight(function(val) { return val }));
OLDNEW
« no previous file with comments | « src/array.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698