Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 614683004: Revert "Make va_list a struct on X86-32 to match PNaCl." (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
khimg
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Revert "Make va_list a struct on X86-32 to match PNaCl." This reverts commit 5e4e74a0ccc2757783ccf26f68cac1ef2cadb126. Since nacl-clang was not modified this ends up being a mismatch. Revert to match again. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3650 R=khim@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=7faaabb9f10e6dcae5f2b799da43e236e65cda95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -69 lines) Patch
M gcc/config/i386/i386.c View 7 chunks +2 lines, -69 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
khimg
LGTM Just please don't pick that change via NACL_GCC_COMMIT variable in native_client/tools/REVISIONS file without changing ...
6 years, 2 months ago (2014-10-04 15:08:11 UTC) #2
jvoung (off chromium)
On 2014/10/04 15:08:11, khimg wrote: > LGTM > > Just please don't pick that change ...
6 years, 2 months ago (2014-10-04 21:41:57 UTC) #3
jvoung (off chromium)
6 years, 2 months ago (2014-10-08 00:03:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7faaabb9f10e6dcae5f2b799da43e236e65cda95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698