Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 614683002: Fix a DCHECK failure by registering a handler for 'dialogClose' message. (Closed)

Created:
6 years, 2 months ago by babu
Modified:
6 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a DCHECK failure by registering a handler for 'dialogClose' message. This fixes a DCHECK failure on chrome://print, where no handler was registered to handle chrome.send("dialogClose"). BUG=416783 Committed: https://crrev.com/60d2c270d92b1510c8a371d653ad1a6f7f41326b Cr-Commit-Position: refs/heads/master@{#297199}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
babu
6 years, 2 months ago (2014-09-29 08:49:15 UTC) #2
Evan Stade
lgtm
6 years, 2 months ago (2014-09-29 15:27:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614683002/1
6 years, 2 months ago (2014-09-29 15:32:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d68bf7cc32706ffdf5c71b078246a964d53189e2
6 years, 2 months ago (2014-09-29 17:30:16 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 17:31:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60d2c270d92b1510c8a371d653ad1a6f7f41326b
Cr-Commit-Position: refs/heads/master@{#297199}

Powered by Google App Engine
This is Rietveld 408576698