Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 614673002: Port ChromeVox navigation manager and user commands tests. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Port ChromeVox navigation manager and user commands tests. BUG=371692 Committed: https://crrev.com/182d382a6b785b295a0c8e456046332b3fb52768 Cr-Commit-Position: refs/heads/master@{#297159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1521 lines, -0 lines) Patch
A chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager_test.unitjs View 1 chunk +1396 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs View 1 chunk +123 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
6 years, 2 months ago (2014-09-29 08:14:50 UTC) #2
Peter Lundblad
lgtm
6 years, 2 months ago (2014-09-29 12:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614673002/1
6 years, 2 months ago (2014-09-29 12:02:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b4dcc3d9fae6cc54c520a2f627c2ab2396d23d3b
6 years, 2 months ago (2014-09-29 12:06:45 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 12:07:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/182d382a6b785b295a0c8e456046332b3fb52768
Cr-Commit-Position: refs/heads/master@{#297159}

Powered by Google App Engine
This is Rietveld 408576698