Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Unified Diff: mojo/shell/external_application_registrar_connection.h

Issue 614663003: Change ExternalApplicationRegistrar::Register API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/external_application_registrar_connection.h
diff --git a/mojo/shell/external_application_registrar_connection.h b/mojo/shell/external_application_registrar_connection.h
index 327d19b484153ae183b50262549ca8154b8c5704..65c95e633915693634499a9c3b5bdd002696447e 100644
--- a/mojo/shell/external_application_registrar_connection.h
+++ b/mojo/shell/external_application_registrar_connection.h
@@ -41,12 +41,8 @@ class ExternalApplicationRegistrarConnection : public ErrorHandler {
void Connect(const net::CompletionCallback& callback);
// Registers this app with the shell at the provided URL.
- // shell is not ready for use until register_complete_callback fires.
- // TODO(cmasone): Once the pipe for shell can be placed in a FIFO relationship
- // with the one underlying registrar_, the callback becomes unneeded.
void Register(const GURL& app_url,
- ShellPtr* shell,
- base::Closure register_complete_callback);
+ base::Callback<void(ShellPtr)> register_complete_callback);
private:
// Handles the result of Connect(). If it was successful, promotes the socket
« no previous file with comments | « mojo/shell/external_application_registrar.mojom ('k') | mojo/shell/external_application_registrar_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698