Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: src/hydrogen.h

Issue 61463005: Supported folding of constant size allocation followed by dynamic size allocation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebasing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen-instructions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index a117c551ad6171b8f65527be34be799a541d979d..f360a5e8e963d1fe8a570e9ed95ec34b45e6c266 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -1642,8 +1642,7 @@ class HGraphBuilder {
}
HValue* EmitInternalMapCode();
- HValue* EstablishEmptyArrayAllocationSize();
- HValue* EstablishAllocationSize(HValue* length_node);
+ HValue* EstablishHeaderAllocationSize();
HValue* AllocateArray(HValue* size_in_bytes, HValue* capacity,
HValue* length_field,
FillMode fill_mode = FILL_WITH_HOLE);
@@ -1653,14 +1652,17 @@ class HGraphBuilder {
AllocationSiteMode mode_;
HValue* allocation_site_payload_;
HValue* constructor_function_;
- HInnerAllocatedObject* elements_location_;
+ HValue* elements_location_;
};
HValue* BuildAllocateArrayFromLength(JSArrayBuilder* array_builder,
HValue* length_argument);
+ HValue* BuildCalculateElementsSize(ElementsKind kind,
+ HValue* capacity);
HValue* BuildAllocateElements(ElementsKind kind,
- HValue* capacity);
+ HValue* size_in_bytes,
+ PretenureFlag pretenure);
void BuildInitializeElementsHeader(HValue* elements,
ElementsKind kind,
@@ -1670,15 +1672,14 @@ class HGraphBuilder {
HValue* capacity);
// array must have been allocated with enough room for
Hannes Payer (out of office) 2013/11/21 12:07:19 Can you change "array" to "Array".
Igor Sheludko 2013/11/27 12:52:01 Done.
- // 1) the JSArray, 2) a AllocationMemento if mode requires it,
- // 3) a FixedArray or FixedDoubleArray.
- // A pointer to the Fixed(Double)Array is returned.
- HInnerAllocatedObject* BuildJSArrayHeader(HValue* array,
- HValue* array_map,
- AllocationSiteMode mode,
- ElementsKind elements_kind,
- HValue* allocation_site_payload,
- HValue* length_field);
+ // 1) the JSArray, 2) a AllocationMemento if mode requires it.
Hannes Payer (out of office) 2013/11/21 12:07:19 -instead of "," -> "and" -an AllocationMemento
Igor Sheludko 2013/11/27 12:52:01 Done.
+ // Initially the array elements storage is initialized with empty array.
+ void BuildJSArrayHeader(HValue* array,
+ HValue* array_map,
+ AllocationSiteMode mode,
+ ElementsKind elements_kind,
+ HValue* allocation_site_payload,
+ HValue* length_field);
HValue* BuildGrowElementsCapacity(HValue* object,
HValue* elements,
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | src/hydrogen-instructions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698