Issue 61463003: file_manager: Rename file_manager::FileManagerInstaller to file_manager::AppInstaller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 61463003: file_manager: Rename file_manager::FileManagerInstaller to file_manager::AppInstaller (Closed)

Created:
7 years, 1 month ago by satorux1

Modified:
7 years, 1 month ago

Reviewers:
yoshiki

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Rename file_manager::FileManagerInstaller to file_manager::AppInstaller Revise the class comment along the way. BUG=284984 TEST=none R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233234

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -207 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/chromeos/file_manager/app_installer.h	View	3 chunks	+10 lines, -9 lines	0 comments	Download
A +	chrome/browser/chromeos/file_manager/app_installer.cc	View	7 chunks	+15 lines, -15 lines	0 comments	Download
D	chrome/browser/chromeos/file_manager/file_manager_installer.h	View	1 chunk	+0 lines, -65 lines	0 comments	Download
D	chrome/browser/chromeos/file_manager/file_manager_installer.cc	View	1 chunk	+0 lines, -113 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/61463003/1

7 years, 1 month ago (2013-11-06 05:55:50 UTC) #3

satorux1

7 years, 1 month ago (2013-11-06 06:18:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r233234 (presubmit successful).

Expand Messages | Collapse Messages