Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 614553002: Make sure the IME composition is canceled before forwarding the mouse pressed event. (Closed)

Created:
6 years, 2 months ago by Shu Chen
Modified:
6 years, 2 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, kevers, Yusuke Sato
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make sure the IME composition is canceled before forwarding the mouse pressed event. BUG=418385 TEST=Verified on linux_chromeos. Committed: https://crrev.com/83844c3107e86d2e3b052cffda886cc31b4f1250 Cr-Commit-Position: refs/heads/master@{#298395}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : added an unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 4 chunks +11 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Shu Chen
Sadrul/Yusuke, can you please review this cl? Thanks
6 years, 2 months ago (2014-09-28 06:37:57 UTC) #2
sadrul
This should have a test.
6 years, 2 months ago (2014-09-30 03:04:58 UTC) #3
Shu Chen
On 2014/09/30 03:04:58, sadrul (OOO until late Oct) wrote: > This should have a test. ...
6 years, 2 months ago (2014-10-06 14:35:25 UTC) #4
Shu Chen
+sky@ since sadrul@ is OOO. sky@, can you please review this cl? Thanks!
6 years, 2 months ago (2014-10-06 14:37:12 UTC) #6
sky
LGTM
6 years, 2 months ago (2014-10-06 18:13:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614553002/40001
6 years, 2 months ago (2014-10-07 04:32:07 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 5f32c86710788590a47735877d2b57ab81e1f346
6 years, 2 months ago (2014-10-07 05:58:45 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:59:45 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/83844c3107e86d2e3b052cffda886cc31b4f1250
Cr-Commit-Position: refs/heads/master@{#298395}

Powered by Google App Engine
This is Rietveld 408576698