[Android] Fall back to unthemed resources when loading handle resources

[Android] Fall back to unthemed resources when loading handle resources

Custom Android OS flavors often tailor themed resources, sometimes in a
way that Chrome does not expect or cannot anticipate. As a fallback
measure, acquire the selection handle resources from the unthemed
context resources when themed resource loading fails.

BUG=416081
Committed: https://crrev.com/f100da57e4dd2917943431c8b40db5ba0717e706
Cr-Commit-Position: refs/heads/master@{#297849}

[jdduke (slow), 2014-09-26 23:57:30]

jdduke@chromium.org changed reviewers:
+ sievers@chromium.org

[jdduke (slow), 2014-09-26 23:57:30]

sievers@: PTAL, thanks. I'd still like to find a CyanogenMod build that's
causing this problem (it seems to be a very particular Nexus 5 flavor, that or
this "Meizu" branded phone).

[no sievers, 2014-09-29 18:59:46]

sievers@chromium.org changed reviewers:
+ tedchoc@chromium.org

[no sievers, 2014-09-29 19:01:48]

Maybe Ted or someone else should take a look at this instead.

[jdduke (slow), 2014-09-29 19:32:11]

https://codereview.chromium.org/614463002/diff/20001/content/public/android/j...
File
content/public/android/java/src/org/chromium/content/browser/input/HandleViewResources.java
(right):

https://codereview.chromium.org/614463002/diff/20001/content/public/android/j...
content/public/android/java/src/org/chromium/content/browser/input/HandleViewResources.java:90:
// Always prefer loading resources from the application context, only
Ted, do you know why using the context from ContentViewCore in Chrome would
prevent us from getting themed drawables? That is, if use that context with
upstream shell builds, I get theming, but when I use that with downstream
builds, no theming.  Using the application context seems to work around the
issue, but it seems a hacky workaround.

[jdduke (slow), 2014-10-01 15:31:26]

jdduke@chromium.org changed reviewers:
+ mkosiba@chromium.org

[jdduke (slow), 2014-10-01 15:31:27]

mkosiba@: PTAL. This is rather messy, so if you can think of a cleaner way to
achieve the desired result...

[mkosiba (inactive), 2014-10-01 16:03:21]

sigh.. no idea if there is a better way, LGTM.
I too would prefer to get my hands on a repro first, since it may turn out to be
a third thing...

[jdduke (slow), 2014-10-02 15:47:55]

On 2014/10/01 16:03:21, mkosiba wrote:
> sigh.. no idea if there is a better way, LGTM.
> I too would prefer to get my hands on a repro first, since it may turn out to
be
> a third thing...

Yeah, I flashed a N5 with the same custom kernel as in most crash reports, same
ROM flavor, tried a ton of different themes, still no crash...

[jdduke (slow), 2014-10-02 15:48:17]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-10-02 15:49:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/614463002/40001

[Ted C, 2014-10-02 16:26:38]

On 2014/09/29 19:32:11, jdduke wrote:
>
https://codereview.chromium.org/614463002/diff/20001/content/public/android/j...
> File
>
content/public/android/java/src/org/chromium/content/browser/input/HandleViewResources.java
> (right):
> 
>
https://codereview.chromium.org/614463002/diff/20001/content/public/android/j...
>
content/public/android/java/src/org/chromium/content/browser/input/HandleViewResources.java:90:
> // Always prefer loading resources from the application context, only
> Ted, do you know why using the context from ContentViewCore in Chrome would
> prevent us from getting themed drawables? That is, if use that context with
> upstream shell builds, I get theming, but when I use that with downstream
> builds, no theming.  Using the application context seems to work around the
> issue, but it seems a hacky workaround.

This might be similar to:
https://code.google.com/p/chromium/issues/detail?id=416692

It might be because we are using the AppCompat theme for downstream, but maybe
just using Holo.Light directly for content shell/chrome shell.  But nothing
jumps out to what might be causing this.

[commit-bot: I haz the power, 2014-10-02 16:36:21]

Committed patchset #3 (id:40001) as fbbb48e4ac4be2f393028bc2b8d0e0dccf997488

[commit-bot: I haz the power, 2014-10-02 16:37:06]

Patchset 3 (id:??) landed as
https://crrev.com/f100da57e4dd2917943431c8b40db5ba0717e706
Cr-Commit-Position: refs/heads/master@{#297849}