Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 614453002: Revert of Roll Clang 216630:217949 (Closed)

Created:
6 years, 2 months ago by hans
Modified:
6 years, 2 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Clang 216630:217949 (patchset #5 id:80001 of https://codereview.chromium.org/587433002/) Reason for revert: Reverting due to http://crbug.com/418234. Clang was branching on undefined values. Original issue's description: > Roll Clang 216630:217949 > > Also make the script revert local changes before 'svn co' > rather than afterwards to avoid merge conflicts if a previously > patched file changes upstream. > > BUG=410810 > > Committed: https://crrev.com/ba4cf8bb6dc77ea033fe13989eb604d6069daa97 > Cr-Commit-Position: refs/heads/master@{#296870} TBR=thakis@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=410810 Committed: https://crrev.com/ad66334103b9b9a3129e98fc9decbc0c94c9aa11 Cr-Commit-Position: refs/heads/master@{#297073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/clang/scripts/update.sh View 5 chunks +37 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hans
Created Revert of Roll Clang 216630:217949
6 years, 2 months ago (2014-09-26 23:45:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614453002/1
6 years, 2 months ago (2014-09-26 23:46:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3c80ac9fd48da3d11852eecd6999053d6d84c56c
6 years, 2 months ago (2014-09-26 23:46:55 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ad66334103b9b9a3129e98fc9decbc0c94c9aa11 Cr-Commit-Position: refs/heads/master@{#297073}
6 years, 2 months ago (2014-09-26 23:48:01 UTC) #4
Nico
(This looks superficially similar to https://code.google.com/p/chromium/issues/detail?id=399852#c6 and #c8. I think this is working as expected.) ...
6 years, 2 months ago (2014-09-27 05:39:26 UTC) #5
hans
6 years, 2 months ago (2014-09-27 18:27:39 UTC) #6
Message was sent while issue was closed.
On 2014/09/27 05:39:26, Nico (away until Oct 27) wrote:
> (This looks superficially similar to
> https://code.google.com/p/chromium/issues/detail?id=399852#c6 and #c8. I
> think this is working as expected.)

Thanks for the link! I hadn't seen this before.

After discussing this with LLVM folks we concluded that the generated code is
fine and we should just add Valgrind suppressions. Since LLVM has been doing
this for a very long time and it's only raised Valgrind reports a couple of
times it doesn't seem like a big problem.

I plan to land the roll again on Monday when I have time to watch it.

Powered by Google App Engine
This is Rietveld 408576698