Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 614413003: Added os to input_api (Closed)

Created:
6 years, 2 months ago by pgervais
Modified:
6 years, 2 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : only export os.path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M presubmit_support.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pgervais
I'm adding this to presubmit to be able to use os.stat to know if a ...
6 years, 2 months ago (2014-10-01 21:46:41 UTC) #2
M-A Ruel
Ok but then you become the official owner. That's good? If so, lgtm
6 years, 2 months ago (2014-10-02 22:20:00 UTC) #3
iannucci
https://chromiumcodereview.appspot.com/614413003/diff/1/presubmit_support.py File presubmit_support.py (right): https://chromiumcodereview.appspot.com/614413003/diff/1/presubmit_support.py#newcode295 presubmit_support.py:295: self.os = os I would add os_stat instead. Don't ...
6 years, 2 months ago (2014-10-02 23:13:16 UTC) #5
pgervais
On 2014/10/02 23:13:16, iannucci wrote: > https://chromiumcodereview.appspot.com/614413003/diff/1/presubmit_support.py > File presubmit_support.py (right): > > https://chromiumcodereview.appspot.com/614413003/diff/1/presubmit_support.py#newcode295 > ...
6 years, 2 months ago (2014-10-02 23:21:28 UTC) #6
pgervais
6 years, 2 months ago (2014-10-02 23:23:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 292291.

Powered by Google App Engine
This is Rietveld 408576698