Added Aura notification that relaunch and powerwash is required in case of downgrade.

chrome/browser/chromeos/upgrade_detector_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/upgrade_detector_chromeos.h"
 
 #include "base/memory/singleton.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 
+using chromeos::DBusThreadManager;
+using chromeos::UpdateEngineClient;
+
 namespace {
 
 // How long to wait (each cycle) before checking which severity level we should
 // be at. Once we reach the highest severity, the timer will stop.
 const int kNotifyCycleTimeMs = 20 * 60 * 1000;  // 20 minutes.
 
+bool IsTargetChannelMoreStable(const std::string& current_channel,
+                               const std::string& target_channel) {

[stevenjb, 2014/10/01 22:26:44]

This should either be moved to UpdateEngineClient (where hopefully
:kReleaseChannelsList is reasonably well documented), or should be documented
here, it's not obvious why this works.
 

[ygorshenin1, 2014/10/02 14:21:35]

Done.

+  const auto& channels_list = UpdateEngineClient::kReleaseChannelsList;
+  auto cix =
+      std::find(channels_list.cbegin(), channels_list.cend(), current_channel);
+  auto tix =
+      std::find(channels_list.cbegin(), channels_list.cend(), target_channel);
+  return tix > cix;
+}
+
 }  // namespace
 
-using chromeos::DBusThreadManager;
-using chromeos::UpdateEngineClient;
+class UpgradeDetectorChromeos::ChannelsRequester {
+ public:
+  ChannelsRequester() : weak_factory_(this) {}
 
-UpgradeDetectorChromeos::UpgradeDetectorChromeos() : initialized_(false) {
+  void RequestChannels(const base::Callback<
+      void(const std::string&, const std::string&)>& callback) {

[stevenjb, 2014/10/01 22:26:44]

This callback should be typedfed somewhere

[ygorshenin1, 2014/10/02 14:21:35]

Done.

+    UpdateEngineClient* client =
+        DBusThreadManager::Get()->GetUpdateEngineClient();
+    callback_ = callback;
+    client->GetChannel(true /* get_current_channel */,
+                       base::Bind(&ChannelsRequester::SetCurrentChannel,
+                                  weak_factory_.GetWeakPtr()));
+    client->GetChannel(false /* get_current_channel */,
+                       base::Bind(&ChannelsRequester::SetTargetChannel,
+                                  weak_factory_.GetWeakPtr()));
+  }
+
+ private:
+  void SetCurrentChannel(const std::string& current_channel) {

[stevenjb, 2014/10/01 22:26:44]

DCHECK(!current_channel.empty()), otherwise an empty result will cause
TriggerCallbackIfReady to never fire.

[ygorshenin1, 2014/10/02 14:21:35]

Done.

+    current_channel_ = current_channel;
+    TriggerCallbackIfReady();
+  }
+
+  void SetTargetChannel(const std::string& target_channel) {

[stevenjb, 2014/10/01 22:26:44]

Ditto.

[ygorshenin1, 2014/10/02 14:21:35]

Done.

+    target_channel_ = target_channel;
+    TriggerCallbackIfReady();
+  }
+
+  void TriggerCallbackIfReady() {
+    if (current_channel_.empty() || target_channel_.empty())
+      return;
+    if (!callback_.is_null())
+      callback_.Run(current_channel_, target_channel_);
+  }
+
+  std::string current_channel_;
+  std::string target_channel_;
+
+  base::Callback<void(const std::string&, const std::string&)> callback_;
+
+  base::WeakPtrFactory<ChannelsRequester> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChannelsRequester);
+};
+
+UpgradeDetectorChromeos::UpgradeDetectorChromeos()
+    : initialized_(false), weak_factory_(this) {
 }
 
 UpgradeDetectorChromeos::~UpgradeDetectorChromeos() {
 }
 
 void UpgradeDetectorChromeos::Init() {
   DBusThreadManager::Get()->GetUpdateEngineClient()->AddObserver(this);
   initialized_ = true;
 }
 
 void UpgradeDetectorChromeos::Shutdown() {
   // Init() may not be called from tests.
   if (!initialized_)
     return;
   DBusThreadManager::Get()->GetUpdateEngineClient()->RemoveObserver(this);
 }
 
 void UpgradeDetectorChromeos::UpdateStatusChanged(
     const UpdateEngineClient::Status& status) {
   if (status.status != UpdateEngineClient::UPDATE_STATUS_UPDATED_NEED_REBOOT)
     return;
 
   upgrade_detected_time_ = base::Time::Now();
 
-  // ChromeOS shows upgrade arrow once the upgrade becomes available.
-  NotifyOnUpgrade();
-
-  // Setup timer to to move along the upgrade advisory system.
-  upgrade_notification_timer_.Start(
-      FROM_HERE, base::TimeDelta::FromMilliseconds(kNotifyCycleTimeMs),
-      this, &UpgradeDetectorChromeos::NotifyOnUpgrade);
+  channels_requester_.reset(new UpgradeDetectorChromeos::ChannelsRequester());
+  channels_requester_->RequestChannels(
+      base::Bind(&UpgradeDetectorChromeos::OnChannelsReceived,
+                 weak_factory_.GetWeakPtr()));
 }
 
 void UpgradeDetectorChromeos::NotifyOnUpgrade() {
   base::TimeDelta delta = base::Time::Now() - upgrade_detected_time_;
   int64 time_passed = delta.InDays();
 
   const int kSevereThreshold = 7;
   const int kHighThreshold = 4;
   const int kElevatedThreshold = 2;
   const int kLowThreshold = 0;
@@ skipping 10 matching lines @@
     set_upgrade_notification_stage(UPGRADE_ANNOYANCE_ELEVATED);
   } else if (time_passed >= kLowThreshold) {
     set_upgrade_notification_stage(UPGRADE_ANNOYANCE_LOW);
   } else {
     return;  // Not ready to recommend upgrade.
   }
 
   NotifyUpgradeRecommended();
 }
 
+void UpgradeDetectorChromeos::OnChannelsReceived(
+    const std::string& current_channel,
+    const std::string& target_channel) {
+  set_is_factory_reset_required(
+      IsTargetChannelMoreStable(current_channel, target_channel));

[stevenjb, 2014/10/01 22:26:44]

Could you add a comment explaining why IsTargetChannelMoreStable corresponds to
factory_reset_required?

[ygorshenin1, 2014/10/02 14:21:35]

Done.

+
+  // ChromeOS shows upgrade arrow once the upgrade becomes available.
+  NotifyOnUpgrade();
+
+  // Setup timer to to move along the upgrade advisory system.
+  upgrade_notification_timer_.Start(
+      FROM_HERE,
+      base::TimeDelta::FromMilliseconds(kNotifyCycleTimeMs),
+      this,
+      &UpgradeDetectorChromeos::NotifyOnUpgrade);
+}
+
 // static
 UpgradeDetectorChromeos* UpgradeDetectorChromeos::GetInstance() {
   return Singleton<UpgradeDetectorChromeos>::get();
 }
 
 // static
 UpgradeDetector* UpgradeDetector::GetInstance() {
   return UpgradeDetectorChromeos::GetInstance();
 }