DevTools: enable by default disableAgentsWhenProfile experiment

Source/devtools/front_end/sdk/DebuggerModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 35 matching lines @@
     this._scripts = {};
     /** @type {!StringMap.<!Array.<!WebInspector.Script>>} */
     this._scriptsBySourceURL = new StringMap();
 
     /** @type {!WebInspector.Object} */
     this._breakpointResolvedEventTarget = new WebInspector.Object();
 
     this._isPausing = false;
     WebInspector.settings.pauseOnExceptionEnabled.addChangeListener(this._pauseOnExceptionStateChanged, this);
     WebInspector.settings.pauseOnCaughtException.addChangeListener(this._pauseOnExceptionStateChanged, this);
-
-    WebInspector.settings.enableAsyncStackTraces.addChangeListener(this._asyncStackTracesStateChanged, this);
-    WebInspector.profilingLock().addEventListener(WebInspector.Lock.Events.StateChanged, this._profilingStateChanged, this);
+    WebInspector.settings.enableAsyncStackTraces.addChangeListener(this.asyncStackTracesStateChanged, this);
+    WebInspector.settings.skipStackFramesPattern.addChangeListener(this._applySkipStackFrameSettings, this);
+    WebInspector.settings.skipContentScripts.addChangeListener(this._applySkipStackFrameSettings, this);
 
     this.enableDebugger();
 
-    WebInspector.settings.skipStackFramesPattern.addChangeListener(this._applySkipStackFrameSettings, this);
-    WebInspector.settings.skipContentScripts.addChangeListener(this._applySkipStackFrameSettings, this);
     this._applySkipStackFrameSettings();
 }
 
 /** @typedef {{location: ?WebInspector.DebuggerModel.Location, sourceURL: ?string, functionName: string, scopeChain: (Array.<!DebuggerAgent.Scope>|null)}} */
 WebInspector.DebuggerModel.FunctionDetails;
 
 /**
  * Keep these in sync with WebCore::ScriptDebugServer
  *
  * @enum {string}
@@ skipping 36 matching lines @@
         return !!this._debuggerEnabled;
     },
 
     enableDebugger: function()
     {
         if (this._debuggerEnabled)
             return;
         this._agent.enable();
         this._debuggerEnabled = true;
         this._pauseOnExceptionStateChanged();
-        this._asyncStackTracesStateChanged();
+        this.asyncStackTracesStateChanged();
         this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.DebuggerWasEnabled);
     },
 
     disableDebugger: function()
     {
         if (!this._debuggerEnabled)
             return;
 
         this._agent.disable();
         this._debuggerEnabled = false;
         this._isPausing = false;
+        this.asyncStackTracesStateChanged();
         this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.DebuggerWasDisabled);
     },
 
     /**
      * @param {boolean} skip
      * @param {boolean=} untilReload
      */
     skipAllPauses: function(skip, untilReload)
     {
         if (this._skipAllPausesTimeout) {
@@ skipping 21 matching lines @@
         if (!WebInspector.settings.pauseOnExceptionEnabled.get()) {
             state = WebInspector.DebuggerModel.PauseOnExceptionsState.DontPauseOnExceptions;
         } else if (WebInspector.settings.pauseOnCaughtException.get()) {
             state = WebInspector.DebuggerModel.PauseOnExceptionsState.PauseOnAllExceptions;
         } else {
             state = WebInspector.DebuggerModel.PauseOnExceptionsState.PauseOnUncaughtExceptions;
         }
         this._agent.setPauseOnExceptions(state);
     },
 
-    _profilingStateChanged: function()
+    suspendModel: function()
     {
-        if (Runtime.experiments.isEnabled("disableAgentsWhenProfile")) {
-            if (WebInspector.profilingLock().isAcquired())
-                this.disableDebugger();
-            else
-                this.enableDebugger();
-        }
-        this._asyncStackTracesStateChanged();
+        this.disableDebugger();
     },
 
-    _asyncStackTracesStateChanged: function()
+    resumeModel: function()
+    {
+        this.enableDebugger();
+    },
+
+    asyncStackTracesStateChanged: function()
     {
         const maxAsyncStackChainDepth = 4;
-        var enabled = WebInspector.settings.enableAsyncStackTraces.get() && !WebInspector.profilingLock().isAcquired();
+        var enabled = WebInspector.settings.enableAsyncStackTraces.get() && !WebInspector.targetManager.allTargetsSuspended();
         this._agent.setAsyncCallStackDepth(enabled ? maxAsyncStackChainDepth : 0);
     },
 
     stepInto: function()
     {
         /**
          * @this {WebInspector.DebuggerModel}
          */
         function callback()
         {
@@ skipping 520 matching lines @@
     {
         this._breakpointResolvedEventTarget.removeEventListener(breakpointId, listener, thisObject);
     },
 
     dispose: function()
     {
         WebInspector.settings.pauseOnExceptionEnabled.removeChangeListener(this._pauseOnExceptionStateChanged, this);
         WebInspector.settings.pauseOnCaughtException.removeChangeListener(this._pauseOnExceptionStateChanged, this);
         WebInspector.settings.skipStackFramesPattern.removeChangeListener(this._applySkipStackFrameSettings, this);
         WebInspector.settings.skipContentScripts.removeChangeListener(this._applySkipStackFrameSettings, this);
-        WebInspector.settings.enableAsyncStackTraces.removeChangeListener(this._asyncStackTracesStateChanged, this);
+        WebInspector.settings.enableAsyncStackTraces.removeChangeListener(this.asyncStackTracesStateChanged, this);
     },
 
     __proto__: WebInspector.SDKModel.prototype
 }
 
 WebInspector.DebuggerEventTypes = {
     JavaScriptPause: 0,
     JavaScriptBreakpoint: 1,
     NativeBreakpoint: 2
 };
@@ skipping 364 matching lines @@
         return this.target().runtimeModel.createRemoteObject(/** @type {!RuntimeAgent.RemoteObject} */(this.auxData));
     },
 
     __proto__: WebInspector.SDKObject.prototype
 }
 
 /**
  * @type {!WebInspector.DebuggerModel}
  */
 WebInspector.debuggerModel;