DevTools: enable by default disableAgentsWhenProfile experiment

Source/devtools/front_end/elements/ElementsTreeOutline.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 1122 matching lines @@
         return this._expandedChildrenLimit;
     },
 
     set expandedChildrenLimit(x)
     {
         if (this._expandedChildrenLimit === x)
             return;
 
         this._expandedChildrenLimit = x;
         if (this.treeOutline && !this._updateChildrenInProgress)
-            this._updateChildren(true);
+            this._updateChildren(true, this.children);
     },
 
     get expandedChildCount()
     {
         var count = this.children.length;
         if (count && this.children[count - 1]._elementCloseTag)
             count--;
         if (count && this.children[count - 1].expandAllButton)
             count--;
         return count;
     },
 
     /**
      * @param {!WebInspector.DOMNode} child
      * @return {?WebInspector.ElementsTreeElement}
      */
     _showChild: function(child)
     {
         if (this._elementCloseTag)
             return null;
 
         var index = this._visibleChildren().indexOf(child);
         if (index === -1)
             return null;
 
         if (index >= this.expandedChildrenLimit) {
             this._expandedChildrenLimit = index + 1;
-            this._updateChildren(true);
+            this._updateChildren(true, this.children);
         }
 
         // Whether index-th child is visible in the children tree
         return this.expandedChildCount > index ? this.children[index] : null;
     },
 
     updateSelection: function()
     {
         var listItemElement = this.listItemElement;
         if (!listItemElement)
@@ skipping 50 matching lines @@
     },
 
     /**
      * @param {boolean=} fullRefresh
      */
     updateChildren: function(fullRefresh)
     {
         if (!this.hasChildren)
             return;
         console.assert(!this._elementCloseTag);
-        this._node.getChildNodes(this._updateChildren.bind(this, fullRefresh));
+        this._node.getChildNodes(this._updateChildren.bind(this, fullRefresh || false));
     },
 
     /**
      * @param {!WebInspector.DOMNode} child
      * @param {number} index
      * @param {boolean=} closingTag
      * @return {!WebInspector.ElementsTreeElement}
      */
     insertChildElement: function(child, index, closingTag)
     {
         var newElement = new WebInspector.ElementsTreeElement(child, closingTag);
         newElement.selectable = this.treeOutline._selectEnabled;
         this.insertChild(newElement, index);
         return newElement;
     },
 
     moveChild: function(child, targetIndex)
     {
         var wasSelected = child.selected;
         this.removeChild(child);
         this.insertChild(child, targetIndex);
         if (wasSelected)
             child.select();
     },
 
     /**
-     * @param {boolean=} fullRefresh
+     * @param {boolean} fullRefresh
+     * @param {?Array.<!WebInspector.DOMNode>} children
      */
-    _updateChildren: function(fullRefresh)
+    _updateChildren: function(fullRefresh, children)
     {
-        if (this._updateChildrenInProgress || !this.treeOutline._visible)
+        if (!children || this._updateChildrenInProgress || !this.treeOutline._visible)

[pfeldman, 2014/11/12 17:19:39]

Could reviewers explain why this is needed here?

             return;
 
         this._updateChildrenInProgress = true;
         var selectedNode = this.treeOutline.selectedDOMNode();
         var originalScrollTop = 0;
         if (fullRefresh) {
             var treeOutlineContainerElement = this.treeOutline.element.parentNode;
             originalScrollTop = treeOutlineContainerElement.scrollTop;
             var selectedTreeElement = this.treeOutline.selectedTreeElement;
             if (selectedTreeElement && selectedTreeElement.hasAncestor(this))
@@ skipping 1666 matching lines @@
                 treeOutline.rootDOMNode = node;
                 if (!treeOutline.children[0].hasChildren)
                     treeOutline._element.classList.add("single-node");
                 treeOutline.setVisible(true);
                 treeOutline.element.treeElementForTest = treeOutline.children[0];
                 resolve(treeOutline.element);
             }
         }
     }
 }