DevTools: enable by default disableAgentsWhenProfile experiment

Source/devtools/front_end/profiler/ProfilesPanel.js

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 219 matching lines @@
     {
         return this._profileBeingRecorded;
     },
 
     /**
      * @param {?WebInspector.ProfileHeader} profile
      */
     setProfileBeingRecorded: function(profile)
     {
         if (this._profileBeingRecorded && this._profileBeingRecorded.target())
-            WebInspector.profilingLock().release();
+            WebInspector.targetManager.resumeAllTargets();
         if (profile && profile.target())
-            WebInspector.profilingLock().acquire();
+            WebInspector.targetManager.suspendAllTargets();
         this._profileBeingRecorded = profile;
     },
 
     profileBeingRecordedRemoved: function()
     {
     },
 
     _reset: function()
     {
         var profiles = this._profiles.slice(0);
@@ skipping 231 matching lines @@
     for (var i = 0; i < types.length; i++)
         this._registerProfileType(types[i]);
     this._launcherView.restoreSelectedProfileType();
     this.profilesItemTreeElement.select();
     this._showLauncherView();
 
     this._createFileSelectorElement();
     this.element.addEventListener("contextmenu", this._handleContextMenuEvent.bind(this), true);
     this._registerShortcuts();
 
-    WebInspector.profilingLock().addEventListener(WebInspector.Lock.Events.StateChanged, this._onProfilingStateChanged, this);
+    WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.SuspendStateChanged, this._onSuspendStateChanged, this);
 }
 
 WebInspector.ProfilesPanel.prototype = {
     /**
      * @return {!WebInspector.SearchableView}
      */
     searchableView: function()
     {
         return this._searchableView;
     },
@@ skipping 67 matching lines @@
         if (isProfiling) {
             this._launcherView.profileStarted();
             if (type.hasTemporaryView())
                 this.showProfile(type.profileBeingRecorded());
         } else {
             this._launcherView.profileFinished();
         }
         return true;
     },
 
-    _onProfilingStateChanged: function()
+    _onSuspendStateChanged: function()
     {
         this._updateRecordButton(this.recordButton.toggled);
     },
 
     /**
      * @param {boolean} toggled
      */
     _updateRecordButton: function(toggled)
     {
-        if (Runtime.experiments.isEnabled("disableAgentsWhenProfile"))
-            WebInspector.inspectorView.setCurrentPanelLocked(toggled);
-        var isAcquiredInSomeTarget = WebInspector.profilingLock().isAcquired();
-        var enable = toggled || !isAcquiredInSomeTarget;
+        var areTargetsSuspended = WebInspector.targetManager.areTargetsSuspended();

[aandrey, 2014/10/15 18:14:06]

nit: areTargetsSuspended -> allTargetsSuspended
nit: inline (drop the var)

[loislo, 2014/10/16 09:08:22]

Done.

+        var enable = toggled || !areTargetsSuspended;

[yurys, 2014/10/15 14:07:34]

Should this be 
toggled && !areTargetsSuspended ?

[loislo, 2014/10/15 15:38:47]

we mark the button as enabled if no-one records a profile OR it is toggled (i.e.
we are recording the profile)

         this.recordButton.setEnabled(enable);
         this.recordButton.toggled = toggled;
         if (enable)
             this.recordButton.title = this._selectedProfileType ? this._selectedProfileType.buttonTooltip : "";
         else
             this.recordButton.title = WebInspector.anotherProfilerActiveLabel();
         if (this._selectedProfileType)
             this._launcherView.updateProfileType(this._selectedProfileType, enable);
     },
 
@@ skipping 718 matching lines @@
 
 WebInspector.ProfilesPanelFactory.prototype = {
     /**
      * @return {!WebInspector.Panel}
      */
     createPanel: function()
     {
         return WebInspector.ProfilesPanel._instance();
     }
 }