DevTools: enable by default disableAgentsWhenProfile experiment

Source/devtools/front_end/profiler/CanvasProfileView.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 708 matching lines @@
         } else {
             this._recording = true;
             this._startFrameCapturing();
         }
         return this._recording;
     },
 
     _runSingleFrameCapturing: function()
     {
         var frameId = this._selectedFrameId();
-        WebInspector.profilingLock().acquire();
+        WebInspector.targetManager.suspendAllTargets();

[yurys, 2014/10/15 14:07:34]

Do we really need this call here?

[loislo, 2014/10/15 15:38:47]

aandrey@ knows why it is needed.

[aandrey, 2014/10/15 18:14:06]

It may take some time to capture a single frame too. e.g. while waiting for a
first canvas command.

         CanvasAgent.captureFrame(frameId, this._didStartCapturingFrame.bind(this, frameId));
-        WebInspector.profilingLock().release();
+        WebInspector.targetManager.resumeAllTargets();
     },
 
     _startFrameCapturing: function()
     {
         var frameId = this._selectedFrameId();
-        WebInspector.profilingLock().acquire();
+        WebInspector.targetManager.suspendAllTargets();

[aandrey, 2014/10/15 18:14:06]

This name is misleading. You don't really *suspend* any of the targets.

[loislo, 2014/10/16 09:08:22]

It depends what you mean under name Target.

[aandrey, 2014/10/16 09:49:41]

AFAIU, you disable few agents that may affect profiling results. I'd never guess
that "suspend target" may mean this thing unless I look into implementation
details. The "profilingLock().acquire()" is far more clearer name to me.

         CanvasAgent.startCapturing(frameId, this._didStartCapturingFrame.bind(this, frameId));
     },
 
     _stopFrameCapturing: function()
     {
         if (!this._lastProfileHeader) {
-            WebInspector.profilingLock().release();
+            WebInspector.targetManager.resumeAllTargets();
             return;
         }
         var profileHeader = this._lastProfileHeader;
         var traceLogId = profileHeader.traceLogId();
         this._lastProfileHeader = null;
         function didStopCapturing()
         {
             profileHeader._updateCapturingStatus();
         }
         CanvasAgent.stopCapturing(traceLogId, didStopCapturing);
-        WebInspector.profilingLock().release();
+        WebInspector.targetManager.resumeAllTargets();
     },
 
     /**
      * @param {string|undefined} frameId
      * @param {?Protocol.Error} error
      * @param {!CanvasAgent.TraceLogId} traceLogId
      */
     _didStartCapturingFrame: function(frameId, error, traceLogId)
     {
         if (error || this._lastProfileHeader && this._lastProfileHeader.traceLogId() === traceLogId)
@@ skipping 544 matching lines @@
     },
 
     clearResourceStates: function()
     {
         this._currentResourceStates = {};
         this.dispatchEventToListeners(WebInspector.CanvasTraceLogPlayerProxy.Events.CanvasReplayStateChanged);
     },
 
     __proto__: WebInspector.Object.prototype
 }