Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 614263007: Revert of Making WebRTC Java api avaliable in Chromium. (Closed)

Created:
6 years, 2 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Making WebRTC Java api avaliable in Chromium. (patchset #5 id:100001 of https://codereview.chromium.org/551793003/) Reason for revert: This CL breaks official Chrome. Original issue's description: > Making WebRTC Java api avaliable in Chromium. > > BUG=383418 > TEST=Build target libjingle_peerconnection_javalib > > Committed: https://crrev.com/e65a8cbe2e8b0634a66715b3959b418431f4d0c0 > Cr-Commit-Position: refs/heads/master@{#297801} TBR=hellner@chromium.org,kjellander@chromium.org,serya@chromium.org NOTREECHECKS=true NOTRY=true BUG=383418 Committed: https://crrev.com/98cb056b6dfeb0d95595d0de498acffe500ca3b2 Cr-Commit-Position: refs/heads/master@{#297816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -90 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/libjingle/libjingle.gyp View 3 chunks +5 lines, -49 lines 0 comments Download
D third_party/libjingle/overrides/empty.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Making WebRTC Java api avaliable in Chromium.
6 years, 2 months ago (2014-10-02 12:38:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614263007/1
6 years, 2 months ago (2014-10-02 12:38:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 656b0d68dbae26aea8faaef04848644fab0bb87c
6 years, 2 months ago (2014-10-02 12:39:22 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 12:40:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98cb056b6dfeb0d95595d0de498acffe500ca3b2
Cr-Commit-Position: refs/heads/master@{#297816}

Powered by Google App Engine
This is Rietveld 408576698