Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: LayoutTests/http/tests/media/audio-timeline-seek-outside-seekable.html

Issue 614263002: Drop all timeline seeks outside of the seekable range. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@seek
Patch Set: Rebase. Test. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/http/tests/media/audio-timeline-seek-outside-seekable.html
diff --git a/LayoutTests/http/tests/media/audio-seekable-contains-zero-without-ranges.html b/LayoutTests/http/tests/media/audio-timeline-seek-outside-seekable.html
similarity index 69%
copy from LayoutTests/http/tests/media/audio-seekable-contains-zero-without-ranges.html
copy to LayoutTests/http/tests/media/audio-timeline-seek-outside-seekable.html
index dc23b5d2d256adebf21ac8100444684aede2c44f..ee635ff03bcad1b76372d7eaa0a0ee5adb0b461d 100644
--- a/LayoutTests/http/tests/media/audio-seekable-contains-zero-without-ranges.html
+++ b/LayoutTests/http/tests/media/audio-timeline-seek-outside-seekable.html
@@ -1,8 +1,9 @@
<!DOCTYPE html>
-<title>seekable() ranges contain zero when server doesn't support range requests.</title>
+<title>Verifies timeline control seeks outside of seekable() fizzle.</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<script src="../../media-resources/media-file.js"></script>
+<script src="../../media-resources/media-controls.js"></script>
<div id="log"></div>
<audio controls></audio>
<script>
@@ -15,11 +16,13 @@ async_test(function(t) {
assert_equals(audio.seekable.start(0), 0);
assert_equals(audio.seekable.end(0), 0);
- // Verify seeking to a nonzero position results in a seek to zero.
- audio.currentTime = 1;
- });
+ // Click the middle of the timeline.
+ var coords = mediaControlsButtonCoordinates(audio, "timeline");
+ eventSender.mouseMoveTo(coords[0], coords[1]);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
- audio.onseeked = t.step_func(function() {
+ assert_false(audio.seeking);
assert_equals(audio.currentTime, 0);
t.done();
});
« no previous file with comments | « no previous file | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698