Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc

Issue 614223006: Revert "UMA: How often are different network error screens encountered during OOBE" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_scre en.h" 5 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_scre en.h"
6 6
7 #include "ash/desktop_background/desktop_background_controller.h" 7 #include "ash/desktop_background/desktop_background_controller.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "base/rand_util.h" 9 #include "base/rand_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
11 #include "chrome/browser/chromeos/camera_detector.h" 11 #include "chrome/browser/chromeos/camera_detector.h"
12 #include "chrome/browser/chromeos/login/error_screens_histogram_helper.h"
13 #include "chrome/browser/chromeos/login/existing_user_controller.h" 12 #include "chrome/browser/chromeos/login/existing_user_controller.h"
14 #include "chrome/browser/chromeos/login/screen_manager.h" 13 #include "chrome/browser/chromeos/login/screen_manager.h"
15 #include "chrome/browser/chromeos/login/screens/error_screen.h" 14 #include "chrome/browser/chromeos/login/screens/error_screen.h"
16 #include "chrome/browser/chromeos/login/screens/screen_observer.h" 15 #include "chrome/browser/chromeos/login/screens/screen_observer.h"
17 #include "chrome/browser/chromeos/login/signin_specifics.h" 16 #include "chrome/browser/chromeos/login/signin_specifics.h"
18 #include "chrome/browser/chromeos/login/supervised/supervised_user_authenticatio n.h" 17 #include "chrome/browser/chromeos/login/supervised/supervised_user_authenticatio n.h"
19 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_cont roller.h" 18 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_cont roller.h"
20 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_cont roller_new.h" 19 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_cont roller_new.h"
21 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_flow .h" 20 #include "chrome/browser/chromeos/login/supervised/supervised_user_creation_flow .h"
22 #include "chrome/browser/chromeos/login/users/avatar/user_image_manager.h" 21 #include "chrome/browser/chromeos/login/users/avatar/user_image_manager.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 SupervisedUserCreationScreenHandler* actor) 99 SupervisedUserCreationScreenHandler* actor)
101 : WizardScreen(observer), 100 : WizardScreen(observer),
102 actor_(actor), 101 actor_(actor),
103 on_error_screen_(false), 102 on_error_screen_(false),
104 manager_signin_in_progress_(false), 103 manager_signin_in_progress_(false),
105 last_page_(kNameOfIntroScreen), 104 last_page_(kNameOfIntroScreen),
106 sync_service_(NULL), 105 sync_service_(NULL),
107 image_decoder_(NULL), 106 image_decoder_(NULL),
108 apply_photo_after_decoding_(false), 107 apply_photo_after_decoding_(false),
109 selected_image_(0), 108 selected_image_(0),
110 histogram_helper_(new ErrorScreensHistogramHelper("Supervised")),
111 weak_factory_(this) { 109 weak_factory_(this) {
112 DCHECK(actor_); 110 DCHECK(actor_);
113 if (actor_) 111 if (actor_)
114 actor_->SetDelegate(this); 112 actor_->SetDelegate(this);
115 } 113 }
116 114
117 SupervisedUserCreationScreen::~SupervisedUserCreationScreen() { 115 SupervisedUserCreationScreen::~SupervisedUserCreationScreen() {
118 CameraPresenceNotifier::GetInstance()->RemoveObserver(this); 116 CameraPresenceNotifier::GetInstance()->RemoveObserver(this);
119 if (sync_service_) 117 if (sync_service_)
120 sync_service_->RemoveObserver(this); 118 sync_service_->RemoveObserver(this);
(...skipping 17 matching lines...) Expand all
138 // removed once we have screens reworked. 136 // removed once we have screens reworked.
139 if (on_error_screen_) 137 if (on_error_screen_)
140 actor_->ShowPage(last_page_); 138 actor_->ShowPage(last_page_);
141 else 139 else
142 actor_->ShowIntroPage(); 140 actor_->ShowIntroPage();
143 } 141 }
144 142
145 if (!on_error_screen_) 143 if (!on_error_screen_)
146 NetworkPortalDetector::Get()->AddAndFireObserver(this); 144 NetworkPortalDetector::Get()->AddAndFireObserver(this);
147 on_error_screen_ = false; 145 on_error_screen_ = false;
148 histogram_helper_->OnScreenShow();
149 } 146 }
150 147
151 void SupervisedUserCreationScreen::OnPageSelected(const std::string& page) { 148 void SupervisedUserCreationScreen::OnPageSelected(const std::string& page) {
152 last_page_ = page; 149 last_page_ = page;
153 } 150 }
154 151
155 void SupervisedUserCreationScreen::OnPortalDetectionCompleted( 152 void SupervisedUserCreationScreen::OnPortalDetectionCompleted(
156 const NetworkState* network, 153 const NetworkState* network,
157 const NetworkPortalDetector::CaptivePortalState& state) { 154 const NetworkPortalDetector::CaptivePortalState& state) {
158 if (state.status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_ONLINE) { 155 if (state.status == NetworkPortalDetector::CAPTIVE_PORTAL_STATUS_ONLINE) {
159 get_screen_observer()->HideErrorScreen(this); 156 get_screen_observer()->HideErrorScreen(this);
160 histogram_helper_->OnErrorHide();
161 } else { 157 } else {
162 on_error_screen_ = true; 158 on_error_screen_ = true;
163 ErrorScreen* screen = get_screen_observer()->GetErrorScreen(); 159 ErrorScreen* screen = get_screen_observer()->GetErrorScreen();
164 ConfigureErrorScreen(screen, network, state.status); 160 ConfigureErrorScreen(screen, network, state.status);
165 screen->SetUIState(ErrorScreen::UI_STATE_SUPERVISED); 161 screen->SetUIState(ErrorScreen::UI_STATE_SUPERVISED);
166 get_screen_observer()->ShowErrorScreen(); 162 get_screen_observer()->ShowErrorScreen();
167 histogram_helper_->OnErrorShow(screen->GetErrorState());
168 } 163 }
169 } 164 }
170 165
171 void SupervisedUserCreationScreen::ShowManagerInconsistentStateErrorScreen() { 166 void SupervisedUserCreationScreen::ShowManagerInconsistentStateErrorScreen() {
172 manager_signin_in_progress_ = false; 167 manager_signin_in_progress_ = false;
173 if (!actor_) 168 if (!actor_)
174 return; 169 return;
175 actor_->ShowErrorPage( 170 actor_->ShowErrorPage(
176 l10n_util::GetStringUTF16( 171 l10n_util::GetStringUTF16(
177 IDS_CREATE_SUPERVISED_USER_MANAGER_INCONSISTENT_STATE_TITLE), 172 IDS_CREATE_SUPERVISED_USER_MANAGER_INCONSISTENT_STATE_TITLE),
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 selected_image_ = user_manager::User::USER_IMAGE_EXTERNAL; 614 selected_image_ = user_manager::User::USER_IMAGE_EXTERNAL;
620 } else { 615 } else {
621 NOTREACHED() << "Unexpected image type: " << image_type; 616 NOTREACHED() << "Unexpected image type: " << image_type;
622 } 617 }
623 } 618 }
624 619
625 void SupervisedUserCreationScreen::OnImageAccepted() { 620 void SupervisedUserCreationScreen::OnImageAccepted() {
626 } 621 }
627 622
628 } // namespace chromeos 623 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698