Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 614213003: Domain Reliability: batch update 3/4 (*admob*) (Closed)

Created:
6 years, 2 months ago by Deprecated (see juliatuttle)
Modified:
6 years, 2 months ago
Reviewers:
pavlos, davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Domain Reliability: batch update 3/4 (*admob*) BUG= Committed: https://crrev.com/97236ceff0457864d757b2dd102bd3354626a2d1 Cr-Commit-Position: refs/heads/master@{#299035}

Patch Set 1 #

Patch Set 2 : separate from prior changes #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -102 lines) Patch
M components/domain_reliability.gypi View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M components/domain_reliability/bake_in_configs.py View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M components/domain_reliability/baked_in_configs/c_admob_com.json View 2 chunks +2 lines, -2 lines 0 comments Download
M components/domain_reliability/baked_in_configs/e_admob_com.json View 2 chunks +2 lines, -2 lines 0 comments Download
M components/domain_reliability/baked_in_configs/media_admob_com.json View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_biz.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_co_in.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_co_kr.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_co_nz.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_co_uk.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_co_za.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/domain_reliability/baked_in_configs/star_admob_com.json View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_com_br.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_com_es.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_com_fr.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_com_mx.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_com_pt.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_de.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_dk.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_es.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_fi.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_fr.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_gr.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_hk.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_ie.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_in.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_it.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_jp.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_kr.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_mobi.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_no.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_ph.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_pt.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_sg.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_tw.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_us.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/domain_reliability/baked_in_configs/star_admob_vn.json View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Deprecated (see juliatuttle)
PTAL, davidben.
6 years, 2 months ago (2014-10-01 19:50:22 UTC) #2
Deprecated (see juliatuttle)
pavlos, PTAL at configs
6 years, 2 months ago (2014-10-06 17:15:58 UTC) #4
pavlos
lgtm These are mostly all the admob.ccTLD domains. These configs are copied from an internal ...
6 years, 2 months ago (2014-10-06 17:55:23 UTC) #5
davidben
rubber stamp lgtm. I think we should be pushing for standardizing this thing and removing ...
6 years, 2 months ago (2014-10-08 19:05:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614213003/40001
6 years, 2 months ago (2014-10-09 21:28:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/22625)
6 years, 2 months ago (2014-10-09 22:41:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614213003/40001
6 years, 2 months ago (2014-10-10 01:04:00 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-10 01:39:49 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:05:05 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/97236ceff0457864d757b2dd102bd3354626a2d1
Cr-Commit-Position: refs/heads/master@{#299035}

Powered by Google App Engine
This is Rietveld 408576698