Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 614173002: Define chrome_browser_tests_sources for browser_tests target in chrome_tests.gypi (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, Mr4D (OOO till 08-26)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Define chrome_browser_tests_sources for browser_tests target in chrome_tests.gypi Prep to create browsertest for athena. as it needs to exclude most of tests first. BUG=None Committed: https://crrev.com/a8f6055f5267177932d664b2dc625efd414d4567 Cr-Commit-Position: refs/heads/master@{#297502}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+808 lines, -805 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +808 lines, -805 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
oshima
6 years, 2 months ago (2014-09-30 20:49:56 UTC) #2
oshima
https://codereview.chromium.org/614173002/diff/1/chrome/chrome_tests.gypi File chrome/chrome_tests.gypi (right): https://codereview.chromium.org/614173002/diff/1/chrome/chrome_tests.gypi#newcode6 chrome/chrome_tests.gypi:6: 'chrome_browser_tests_sources': [ let me know if I should create ...
6 years, 2 months ago (2014-09-30 20:50:31 UTC) #3
brettw
LGTM (though I'm not an owner). The test lists would allow the files to be ...
6 years, 2 months ago (2014-09-30 21:09:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614173002/1
6 years, 2 months ago (2014-09-30 21:15:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as de9698e0e8f9cbb43b83cc4427cbb05bc72fea47
6 years, 2 months ago (2014-09-30 21:27:07 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 21:27:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8f6055f5267177932d664b2dc625efd414d4567
Cr-Commit-Position: refs/heads/master@{#297502}

Powered by Google App Engine
This is Rietveld 408576698