Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 614163002: Force linking of static member variables for GLPrograms (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Force linking of static member variables for GLPrograms BUG=skia: Committed: https://skia.googlesource.com/skia/+/9e87fa7c0e52a79ad85bf32eeb71570938e357bd

Patch Set 1 #

Patch Set 2 : windows friendly #

Patch Set 3 : vendor test in gl programs #

Patch Set 4 : desktop gl or arm only #

Patch Set 5 : fix for xoom #

Patch Set 6 : fix for xoom take 2 #

Patch Set 7 : xoom try 3 #

Patch Set 8 : cleanup #

Patch Set 9 : #

Total comments: 4

Patch Set 10 : feedback incorporated #

Patch Set 11 : rebase #

Patch Set 12 : rebase #

Patch Set 13 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -47 lines) Patch
M include/gpu/GrProcessorUnitTest.h View 1 2 3 4 5 6 7 8 9 2 chunks +22 lines, -21 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +44 lines, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +16 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joshua.litt
I'm going to add a define to override the android static settings next week, but ...
6 years, 2 months ago (2014-10-01 18:20:21 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/614163002/diff/160001/tests/GLProgramsTest.cpp File tests/GLProgramsTest.cpp (right): https://codereview.chromium.org/614163002/diff/160001/tests/GLProgramsTest.cpp#newcode134 tests/GLProgramsTest.cpp:134: header->fExperimentalGS = gpu->caps()->geometryShaderSupport() && useGS && Feel free ...
6 years, 2 months ago (2014-10-01 19:40:58 UTC) #3
robertphillips
https://codereview.chromium.org/614163002/diff/160001/include/gpu/GrProcessorUnitTest.h File include/gpu/GrProcessorUnitTest.h (right): https://codereview.chromium.org/614163002/diff/160001/include/gpu/GrProcessorUnitTest.h#newcode37 include/gpu/GrProcessorUnitTest.h:37: Could we make this SK_ATTRIBUTE_UNUSED and put it in ...
6 years, 2 months ago (2014-10-01 19:45:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614163002/240001
6 years, 2 months ago (2014-10-09 19:33:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:12:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #13 (id:240001) as 9e87fa7c0e52a79ad85bf32eeb71570938e357bd

Powered by Google App Engine
This is Rietveld 408576698