Refactoring the GLRenderer::GetBackgroundWithFilters method.

Refactoring the GLRenderer::GetBackgroundWithFilters method.

This patch prepares the existing code for the shader based
implementation of blending: https://codereview.chromium.org/555133002/.

It splits the GetBackgroundWithFilters() functions into multiple chunks,
so that we can have access to the backdrop bounding box and to
the backdrop itself, before being transformed with the inverse matrix.

This patch should not change the current behavior.

BUG=

Committed: https://crrev.com/23ab0f3175ec0c714b03e4851b26d6014f69d4e6
Cr-Commit-Position: refs/heads/master@{#298693}

[rosca, 2014-09-30 17:26:21]

rosca@adobe.com changed reviewers:
+ enne@chromium.org

[rosca, 2014-09-30 17:26:21]

Hi @enne, could you please review this?

[rosca, 2014-10-01 20:49:35]

rosca@adobe.com changed reviewers:
+ danakj@chromium.org

[Erik Dahlström (inactive), 2014-10-06 15:28:34]

ed@opera.com changed reviewers:
+ ed@opera.com

[Erik Dahlström (inactive), 2014-10-06 15:28:35]

Any tests needed for verifying that this doesn't change anything? Rely on
https://codereview.chromium.org/598593005/ catching eventual bugs later on?

Apart from that I think it looks ok, non-owner lgtm.

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:1130: if (background_texture &&
!CanApplyBlendModeUsingBlendFunc(blend_mode)) {
Why not merge the if-statement here with the one on line 1141 (directly below
here)?

[enne (OOO), 2014-10-07 19:52:55]

I think there are already a bunch of tests in
cc/trees/layer_tree_host_pixeltest_blending.cc that should cover this, right?

lgtm

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:1073: // Apply the background filters to R, so that it
is applied in the pixels
Missing apostrophe

[rosca, 2014-10-08 09:32:46]

>> I think there are already a bunch of tests in
>> cc/trees/layer_tree_host_pixeltest_blending.cc that should cover this, right?

Yes, testing should be covered by layer_tree_host_pixeltest_filters.cc,
layer_tree_host_pixeltest_blending.cc and layout tests.

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:1073: // Apply the background filters to R, so that it
is applied in the pixels
On 2014/10/07 19:52:55, enne wrote:
> Missing apostrophe

Done.

https://codereview.chromium.org/614153002/diff/20001/cc/output/gl_renderer.cc...
cc/output/gl_renderer.cc:1130: if (background_texture &&
!CanApplyBlendModeUsingBlendFunc(blend_mode)) {
On 2014/10/06 15:28:35, Erik Dahlström wrote:
> Why not merge the if-statement here with the one on line 1141 (directly below
> here)?

Done.

[rosca, 2014-10-08 10:09:39]

The CQ bit was checked by rosca@adobe.com

[commit-bot: I haz the power, 2014-10-08 10:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/614153002/40001

[commit-bot: I haz the power, 2014-10-08 11:26:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-08 11:26:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rosca, 2014-10-08 12:50:41]

The CQ bit was checked by rosca@adobe.com

[commit-bot: I haz the power, 2014-10-08 12:51:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/614153002/40001

[commit-bot: I haz the power, 2014-10-08 13:23:17]

Committed patchset #3 (id:40001) as 0294ccd13398cf4c5a5fb4d0437499f08e2d39a0

[commit-bot: I haz the power, 2014-10-08 13:24:22]

Patchset 3 (id:??) landed as
https://crrev.com/23ab0f3175ec0c714b03e4851b26d6014f69d4e6
Cr-Commit-Position: refs/heads/master@{#298693}