chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc - Issue 614103007: Error in popup on Link

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 614103007: Error in popup on Link (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

index 3ea7b344e86347c5e810b1f1a0f888bc243a075f..6f1379d03a699e95d6d768fb19146dcfd3848d25 100644

--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

@@ -339,9 +339,13 @@ class InstalledBubbleContent : public views::View,

// Word-wrap the full label text.

const gfx::FontList font_list;

std::vector<base::string16> lines;

- gfx::ElideRectangleText(full_text, font_list, contents_area.width(),

- contents_area.height(), gfx::ELIDE_LONG_WORDS,

- &lines);

+ gfx::ElideRectangleText(full_text,

+ font_list,

+ contents_area.width(),

+ contents_area.height(),

+ gfx::ELIDE_LONG_WORDS,

+ &lines,

+ nullptr);

gfx::Point position = gfx::Point(

contents_area.origin().x() + offset_x,

« no previous file with comments | « ash/system/user/user_card_view.cc ('k') | ui/gfx/canvas_skia.cc » ('j') | ui/gfx/text_elider.cc » ('J')