Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 614083003: Disable findbugs on emma_coverage=1 bots. (Closed)

Created:
6 years, 2 months ago by zty
Modified:
6 years, 2 months ago
Reviewers:
navabi1, navabi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable findbugs on emma_coverage=1 bots. BUG=411131 R=navabi@chromium.org Committed: https://crrev.com/6fd679025ec1e7288c05e15e610de42f45f39ee9 Cr-Commit-Position: refs/heads/master@{#297480}

Patch Set 1 #

Total comments: 2

Patch Set 2 : respond to codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/buildbot/bb_run_bot.py View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
zty
ptal
6 years, 2 months ago (2014-09-30 16:59:42 UTC) #1
navabi
https://codereview.chromium.org/614083003/diff/1/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://codereview.chromium.org/614083003/diff/1/build/android/buildbot/bb_run_bot.py#newcode163 build/android/buildbot/bb_run_bot.py:163: H(std_build_steps + std_host_tests[:1], experimental, let's make this more explicit. ...
6 years, 2 months ago (2014-09-30 17:08:55 UTC) #3
zty
addressed https://codereview.chromium.org/614083003/diff/1/build/android/buildbot/bb_run_bot.py File build/android/buildbot/bb_run_bot.py (right): https://codereview.chromium.org/614083003/diff/1/build/android/buildbot/bb_run_bot.py#newcode163 build/android/buildbot/bb_run_bot.py:163: H(std_build_steps + std_host_tests[:1], experimental, On 2014/09/30 17:08:54, navabi ...
6 years, 2 months ago (2014-09-30 17:16:59 UTC) #4
navabi
lgtm
6 years, 2 months ago (2014-09-30 18:17:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614083003/20001
6 years, 2 months ago (2014-09-30 18:19:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14507) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/20424)
6 years, 2 months ago (2014-09-30 18:30:07 UTC) #9
navabi1
lgtm
6 years, 2 months ago (2014-09-30 18:32:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614083003/20001
6 years, 2 months ago (2014-09-30 19:15:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d702932c975098f66c0fd47cfe10ec0984bf6f2c
6 years, 2 months ago (2014-09-30 19:25:57 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 19:26:43 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6fd679025ec1e7288c05e15e610de42f45f39ee9
Cr-Commit-Position: refs/heads/master@{#297480}

Powered by Google App Engine
This is Rietveld 408576698