Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: cc/surfaces/surface_aggregator_unittest.cc

Issue 614073005: Allow CopyOutputRequests on all render passes of a surface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« cc/surfaces/surface.h ('K') | « cc/surfaces/surface_aggregator.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/compositor_frame.h" 5 #include "cc/output/compositor_frame.h"
6 #include "cc/output/delegated_frame_data.h" 6 #include "cc/output/delegated_frame_data.h"
7 #include "cc/quads/render_pass.h" 7 #include "cc/quads/render_pass.h"
8 #include "cc/quads/render_pass_draw_quad.h" 8 #include "cc/quads/render_pass_draw_quad.h"
9 #include "cc/quads/solid_color_draw_quad.h" 9 #include "cc/quads/solid_color_draw_quad.h"
10 #include "cc/quads/surface_draw_quad.h" 10 #include "cc/quads/surface_draw_quad.h"
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 aggregator_.previous_contained_surfaces().size()); 245 aggregator_.previous_contained_surfaces().size());
246 for (size_t i = 0; i < arraysize(surface_ids); i++) { 246 for (size_t i = 0; i < arraysize(surface_ids); i++) {
247 EXPECT_TRUE( 247 EXPECT_TRUE(
248 aggregator_.previous_contained_surfaces().find(surface_ids[i]) != 248 aggregator_.previous_contained_surfaces().find(surface_ids[i]) !=
249 aggregator_.previous_contained_surfaces().end()); 249 aggregator_.previous_contained_surfaces().end());
250 } 250 }
251 251
252 factory_.Destroy(embedded_surface_id); 252 factory_.Destroy(embedded_surface_id);
253 } 253 }
254 254
255 // Root surface may contain copy requests.
256 TEST_F(SurfaceAggregatorValidSurfaceTest, RootCopyRequest) {
257 SurfaceId embedded_surface_id = allocator_.GenerateId();
258 factory_.Create(embedded_surface_id, SurfaceSize());
259
260 test::Quad embedded_quads[] = {test::Quad::SolidColorQuad(SK_ColorGREEN)};
261 test::Pass embedded_passes[] = {
262 test::Pass(embedded_quads, arraysize(embedded_quads))};
263
264 SubmitFrame(embedded_passes, arraysize(embedded_passes), embedded_surface_id);
265 scoped_ptr<CopyOutputRequest> copy_request(
266 CopyOutputRequest::CreateEmptyRequest());
267 CopyOutputRequest* copy_request_ptr = copy_request.get();
268 scoped_ptr<CopyOutputRequest> copy_request2(
269 CopyOutputRequest::CreateEmptyRequest());
270 CopyOutputRequest* copy_request2_ptr = copy_request2.get();
271
272 test::Quad root_quads[] = {test::Quad::SolidColorQuad(SK_ColorWHITE),
273 test::Quad::SurfaceQuad(embedded_surface_id),
274 test::Quad::SolidColorQuad(SK_ColorBLACK)};
275 test::Quad root_quads2[] = {test::Quad::SolidColorQuad(SK_ColorRED)};
276 test::Pass root_passes[] = {test::Pass(root_quads, arraysize(root_quads)),
277 test::Pass(root_quads2, arraysize(root_quads2))};
278 {
279 RenderPassList pass_list;
280 AddPasses(&pass_list,
281 gfx::Rect(SurfaceSize()),
282 root_passes,
283 arraysize(root_passes));
284 pass_list[0]->copy_requests.push_back(copy_request.Pass());
285 pass_list[1]->copy_requests.push_back(copy_request2.Pass());
286
287 scoped_ptr<DelegatedFrameData> frame_data(new DelegatedFrameData);
288 pass_list.swap(frame_data->render_pass_list);
289
290 scoped_ptr<CompositorFrame> frame(new CompositorFrame);
291 frame->delegated_frame_data = frame_data.Pass();
292
293 factory_.SubmitFrame(root_surface_id_, frame.Pass(), base::Closure());
294 }
295
296 scoped_ptr<CompositorFrame> aggregated_frame =
297 aggregator_.Aggregate(root_surface_id_);
298
299 ASSERT_TRUE(aggregated_frame);
300 ASSERT_TRUE(aggregated_frame->delegated_frame_data);
301
302 DelegatedFrameData* frame_data = aggregated_frame->delegated_frame_data.get();
303
304 test::Quad expected_quads[] = {test::Quad::SolidColorQuad(SK_ColorWHITE),
305 test::Quad::SolidColorQuad(SK_ColorGREEN),
306 test::Quad::SolidColorQuad(SK_ColorBLACK)};
307 test::Pass expected_passes[] = {
308 test::Pass(expected_quads, arraysize(expected_quads)),
309 test::Pass(root_quads2, arraysize(root_quads2))};
310 TestPassesMatchExpectations(expected_passes,
311 arraysize(expected_passes),
312 &frame_data->render_pass_list);
313 ASSERT_EQ(2u, frame_data->render_pass_list.size());
314 ASSERT_EQ(1u, frame_data->render_pass_list[0]->copy_requests.size());
315 DCHECK_EQ(copy_request_ptr,
316 frame_data->render_pass_list[0]->copy_requests[0]);
317 ASSERT_EQ(1u, frame_data->render_pass_list[1]->copy_requests.size());
318 DCHECK_EQ(copy_request2_ptr,
319 frame_data->render_pass_list[1]->copy_requests[0]);
320
321 SurfaceId surface_ids[] = {root_surface_id_, embedded_surface_id};
322 EXPECT_EQ(arraysize(surface_ids),
323 aggregator_.previous_contained_surfaces().size());
324 for (size_t i = 0; i < arraysize(surface_ids); i++) {
325 EXPECT_TRUE(
326 aggregator_.previous_contained_surfaces().find(surface_ids[i]) !=
327 aggregator_.previous_contained_surfaces().end());
328 }
329
330 // Ensure copy requests have been removed from root surface.
331 const CompositorFrame* original_frame =
332 manager_.GetSurfaceForId(root_surface_id_)->GetEligibleFrame();
333 RenderPassList& original_pass_list =
334 original_frame->delegated_frame_data->render_pass_list;
335 ASSERT_EQ(2u, original_pass_list.size());
336 DCHECK(original_pass_list[0]->copy_requests.empty());
337 DCHECK(original_pass_list[1]->copy_requests.empty());
338
339 factory_.Destroy(embedded_surface_id);
340 }
341
255 // This tests referencing a surface that has multiple render passes. 342 // This tests referencing a surface that has multiple render passes.
256 TEST_F(SurfaceAggregatorValidSurfaceTest, MultiPassSurfaceReference) { 343 TEST_F(SurfaceAggregatorValidSurfaceTest, MultiPassSurfaceReference) {
257 SurfaceId embedded_surface_id = allocator_.GenerateId(); 344 SurfaceId embedded_surface_id = allocator_.GenerateId();
258 factory_.Create(embedded_surface_id, SurfaceSize()); 345 factory_.Create(embedded_surface_id, SurfaceSize());
259 346
260 RenderPassId pass_ids[] = {RenderPassId(1, 1), RenderPassId(1, 2), 347 RenderPassId pass_ids[] = {RenderPassId(1, 1), RenderPassId(1, 2),
261 RenderPassId(1, 3)}; 348 RenderPassId(1, 3)};
262 349
263 test::Quad embedded_quads[][2] = { 350 test::Quad embedded_quads[][2] = {
264 {test::Quad::SolidColorQuad(1), test::Quad::SolidColorQuad(2)}, 351 {test::Quad::SolidColorQuad(1), test::Quad::SolidColorQuad(2)},
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
1146 returned_ids[i] = client.returned_resources()[i].id; 1233 returned_ids[i] = client.returned_resources()[i].id;
1147 } 1234 }
1148 EXPECT_THAT(returned_ids, 1235 EXPECT_THAT(returned_ids,
1149 testing::WhenSorted(testing::ElementsAreArray(ids))); 1236 testing::WhenSorted(testing::ElementsAreArray(ids)));
1150 factory.Destroy(surface_id); 1237 factory.Destroy(surface_id);
1151 } 1238 }
1152 1239
1153 } // namespace 1240 } // namespace
1154 } // namespace cc 1241 } // namespace cc
1155 1242
OLDNEW
« cc/surfaces/surface.h ('K') | « cc/surfaces/surface_aggregator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698