Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 614073002: DevTools: Pause on mouse contextmenu event. (Closed)

Created:
6 years, 2 months ago by aandrey
Modified:
6 years, 2 months ago
Reviewers:
vsevik, apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Pause on mouse contextmenu event. R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183151

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/sources/BreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (4 generated)
aandrey
6 years, 2 months ago (2014-09-30 14:53:37 UTC) #1
vsevik
lgtm. context menu could be triggered by special keyboard button so I don't think it ...
6 years, 2 months ago (2014-09-30 16:09:01 UTC) #2
apavlov
https://codereview.chromium.org/614073002/diff/1/Source/devtools/front_end/sources/BreakpointsSidebarPane.js File Source/devtools/front_end/sources/BreakpointsSidebarPane.js (right): https://codereview.chromium.org/614073002/diff/1/Source/devtools/front_end/sources/BreakpointsSidebarPane.js#newcode558 Source/devtools/front_end/sources/BreakpointsSidebarPane.js:558: this._createCategory(WebInspector.UIString("Mouse"), ["click", "dblclick", "mousedown", "mouseup", "mouseover", "mousemove", "mouseout", "mousewheel", ...
6 years, 2 months ago (2014-09-30 16:18:57 UTC) #4
aandrey
On 2014/09/30 16:09:01, vsevik wrote: > lgtm. > context menu could be triggered by special ...
6 years, 2 months ago (2014-09-30 17:22:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614073002/1
6 years, 2 months ago (2014-10-02 15:30:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29912)
6 years, 2 months ago (2014-10-02 16:56:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614073002/1
6 years, 2 months ago (2014-10-02 17:38:25 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:13:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183151

Powered by Google App Engine
This is Rietveld 408576698