Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 614063002: MSan: temporarily blackist a function in sandbox_linux_unittests. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MSan: temporarily blackist a function in sandbox_linux_unittests. This code triggers an MSan issue where we lack an interceptor for sched_getparam(). BUG=418986 TBR=timurrrr@chromium.org NOTRY=true Committed: https://crrev.com/a74c633b26985c9950aecf5e684a06dcaea14eab Cr-Commit-Position: refs/heads/master@{#297419}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/msan/blacklist.txt View 1 chunk +3 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 2 months ago (2014-09-30 14:34:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614063002/1
6 years, 2 months ago (2014-09-30 14:35:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7120e9fff10e5980c4a11505ee51bb55166faef1
6 years, 2 months ago (2014-09-30 14:35:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a74c633b26985c9950aecf5e684a06dcaea14eab Cr-Commit-Position: refs/heads/master@{#297419}
6 years, 2 months ago (2014-09-30 14:36:14 UTC) #5
Timur Iskhodzhanov
6 years, 2 months ago (2014-10-01 10:04:40 UTC) #6
Message was sent while issue was closed.
LGTM with nit

https://codereview.chromium.org/614063002/diff/1/tools/msan/blacklist.txt
File tools/msan/blacklist.txt (right):

https://codereview.chromium.org/614063002/diff/1/tools/msan/blacklist.txt#new...
tools/msan/blacklist.txt:24: # False positives due to an MSan bug.
http://crbug.com/418986
nit: probably "due to missing sched_getparam() interceptor" would be a bit more
useful.

Powered by Google App Engine
This is Rietveld 408576698