Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 614053003: Replace build_angle.gyp with angle.gyp. (Closed)

Created:
6 years, 2 months ago by Jamie Madill
Modified:
6 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace build_angle.gyp with angle.gyp. The final step in switching the angle gyp file will be to remove the temporary angle_gyp variable. BUG=415983 Committed: https://crrev.com/424be9e0114b848c022d07f843f803c87be56be7 Cr-Commit-Position: refs/heads/master@{#297450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_gpu.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/gpu.gyp View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie Madill
PTAL... a small change that touches a lot of files.
6 years, 2 months ago (2014-09-30 14:33:24 UTC) #2
piman
lgtm
6 years, 2 months ago (2014-09-30 15:10:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614053003/1
6 years, 2 months ago (2014-09-30 17:57:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c2c8a8199bb132d0c088e3184d7a7d603b4cce22
6 years, 2 months ago (2014-09-30 18:02:43 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:03:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/424be9e0114b848c022d07f843f803c87be56be7
Cr-Commit-Position: refs/heads/master@{#297450}

Powered by Google App Engine
This is Rietveld 408576698