Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 614023003: DevTools: pass the running test path into the devtools front-end. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
apavlov
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

DevTools: pass the running test path into the devtools front-end. This change passes testPath into the front-end instead of explicitly guessing the active panel. Committed: https://crrev.com/feed35d23406666cca27c61e5b534d22d001a1a8 Cr-Commit-Position: refs/heads/master@{#297421}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/shell/renderer/test_runner/test_interfaces.cc View 1 chunk +11 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
pfeldman
6 years, 2 months ago (2014-09-30 13:50:20 UTC) #2
apavlov
lgtm https://codereview.chromium.org/614023003/diff/1/content/shell/renderer/test_runner/test_interfaces.cc File content/shell/renderer/test_runner/test_interfaces.cc (right): https://codereview.chromium.org/614023003/diff/1/content/shell/renderer/test_runner/test_interfaces.cc#newcode128 content/shell/renderer/test_runner/test_interfaces.cc:128: ",\"lastActivePanel\":\"\\\"%s\\\"\"", let's move this comma into the "{%s%s}" ...
6 years, 2 months ago (2014-09-30 13:59:42 UTC) #3
pfeldman
This whole block with the comma will go away in the next patch!
6 years, 2 months ago (2014-09-30 14:13:34 UTC) #4
pfeldman
This whole block with the comma will go away in the next patch!
6 years, 2 months ago (2014-09-30 14:13:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614023003/1
6 years, 2 months ago (2014-09-30 14:14:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0fc43ec4c4b43982946782bbdc3268d545d4c2f9
6 years, 2 months ago (2014-09-30 14:52:45 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 14:53:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/feed35d23406666cca27c61e5b534d22d001a1a8
Cr-Commit-Position: refs/heads/master@{#297421}

Powered by Google App Engine
This is Rietveld 408576698