components/password_manager/core/browser/password_autofill_manager.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Vaclav's review comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/core/common/password_form_fill_data.cc ('k') | components/password_manager/core/browser/password_autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager.cc b/components/password_manager/core/browser/password_autofill_manager.cc

index 01bf791bed010de8ddfda9ae442a1c79cb34dcd1..fc84a079113c65b494a7e9f75cb9ab15c007557f 100644

--- a/components/password_manager/core/browser/password_autofill_manager.cc

+++ b/components/password_manager/core/browser/password_autofill_manager.cc

@@ -151,8 +151,8 @@ bool PasswordAutofillManager::GetPasswordForUsername(

// fetch the actual password. See crbug.com/178358 for more context.

// Look for any suitable matches to current field text.

- if (fill_data.basic_data.fields[0].value == current_username) {

- *password = fill_data.basic_data.fields[1].value;

+ if (fill_data.username_field.value == current_username) {

+ *password = fill_data.password_field.value;

return true;

}