components/autofill/core/common/autofill_data_validation.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/autofill_data_validation.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Vaclav's review comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/common/password_form_fill_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/autofill_data_validation.cc

diff --git a/components/autofill/core/common/autofill_data_validation.cc b/components/autofill/core/common/autofill_data_validation.cc

index c8f6584a430db08e33717e4c7234fe35c7d62bdc..578cc046c99be4b8caf3e4afe8f6279e68822384 100644

--- a/components/autofill/core/common/autofill_data_validation.cc

+++ b/components/autofill/core/common/autofill_data_validation.cc

@@ -59,9 +59,12 @@ bool IsValidFormData(const FormData& form) {

}

bool IsValidPasswordFormFillData(const PasswordFormFillData& form) {

- if (!IsValidFormData(form.basic_data) ||

- !IsValidString(form.preferred_realm))

+ if (!IsValidString16(form.name) || !IsValidGURL(form.origin) ||

+ !IsValidGURL(form.action) || !IsValidFormFieldData(form.username_field) ||

+ !IsValidFormFieldData(form.password_field) ||

+ !IsValidString(form.preferred_realm)) {

return false;

+ }

for (PasswordFormFillData::LoginCollection::const_iterator it =

form.additional_logins.begin();