components/autofill/content/common/autofill_messages.h - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated Vaclav's review comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | components/autofill/content/renderer/password_autofill_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 25d8277981dcb2355e7f5b637bb87aaaf8a095df..1fb7c1b43e0064eb1ba63993e008e97ef4e5fdfd 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -77,7 +77,12 @@ IPC_STRUCT_TRAITS_BEGIN(autofill::UsernamesCollectionKey)

IPC_STRUCT_TRAITS_END()

IPC_STRUCT_TRAITS_BEGIN(autofill::PasswordFormFillData)

- IPC_STRUCT_TRAITS_MEMBER(basic_data)

+ IPC_STRUCT_TRAITS_MEMBER(name)

+ IPC_STRUCT_TRAITS_MEMBER(origin)

+ IPC_STRUCT_TRAITS_MEMBER(action)

+ IPC_STRUCT_TRAITS_MEMBER(user_submitted)

+ IPC_STRUCT_TRAITS_MEMBER(username_field)

+ IPC_STRUCT_TRAITS_MEMBER(password_field)

IPC_STRUCT_TRAITS_MEMBER(preferred_realm)

IPC_STRUCT_TRAITS_MEMBER(additional_logins)

IPC_STRUCT_TRAITS_MEMBER(other_possible_usernames)