Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 59eff7cc5235d839e224c9b1fa90916d4553389f..556fb22f4b26c99403450cd4554202ac44c2c528 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -710,7 +710,8 @@ void PasswordFormManager::CheckForAccountCreationForm(
// to PasswordForm. Even without this check, these FormStructure's won't
// be uploaded, but it makes it hard to see if we are encountering
// unexpected errors.
- if (!pending.form_data.fields.empty() &&
+ if (!pending.form_data.username_field.name.empty() &&
+ !pending.form_data.password_field.name.empty() &&
pending_structure.FormSignature() !=
observed_structure.FormSignature()) {
UploadPasswordForm(pending.form_data,

Powered by Google App Engine
This is Rietveld 408576698