[Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

components/autofill/core/common/autofill_data_validation.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/autofill_data_validation.h"
 
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "url/gurl.h"
@@ skipping 40 matching lines @@
 
   for (std::vector<FormFieldData>::const_iterator it = form.fields.begin();
        it != form.fields.end(); ++it) {
     if (!IsValidFormFieldData(*it))
       return false;
   }
 
   return true;
 }
 
+bool IsValidPasswordFormData(const PasswordFormFillData& form) {

[Ilya Sherman, 2014/11/04 23:05:31]

If you wanted to factor out this function, it would belong in the anonymous
namespace, so that it's not linkable externally from this file.  However, I
don't think it's actually helpful to pull out this as a helper function, in this
particular case, since it's very little code, and it's only used from one place.
 I'd recommend inlining this code.

[Pritam Nikam, 2014/11/05 05:58:14]

Done.

+  if (!IsValidString16(form.name) || !IsValidGURL(form.origin) ||
+      !IsValidGURL(form.action))
+    return false;
+
+  return IsValidFormFieldData(form.username_field) &&
+         IsValidFormFieldData(form.password_field);
+}
+
 bool IsValidPasswordFormFillData(const PasswordFormFillData& form) {
-  if (!IsValidFormData(form.basic_data) ||
-      !IsValidString(form.preferred_realm))
+  if (!IsValidPasswordFormData(form) || !IsValidString(form.preferred_realm))
     return false;
 
   for (PasswordFormFillData::LoginCollection::const_iterator it =
            form.additional_logins.begin();
        it != form.additional_logins.end(); ++it) {
     if (!IsValidString16(it->first) ||
         !IsValidString16(it->second.password) ||
         !IsValidString(it->second.realm))
       return false;
   }
@@ skipping 31 matching lines @@
   for (std::vector<FormData>::const_iterator it = v.begin(); it != v.end();
        ++it) {
     if (!IsValidFormData(*it))
       return false;
   }
 
   return true;
 }
 
 }  // namespace autofill