Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 614003002: Android Video Capture: use tightest fps Range available on allocate() (Closed)

Created:
6 years, 2 months ago by mcasas
Modified:
6 years, 2 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android Video Capture: use tightest fps Range available on allocate() From the bug descr: > N7 camera list capabilities are like (extracted): > > D/VideoCaptureAndroid(30916): Format 640x480 @ [15000-15000] > D/VideoCaptureAndroid(30916): Format 640x480 @ [24000-24000] > D/VideoCaptureAndroid(30916): Format 640x480 @ [15000-30000] > D/VideoCaptureAndroid(30916): Format 640x480 @ [30000-30000] > > where the second numbers are the frame rate _ranges_. The algorithm for > selecting FPS range in [1] would select the 3rd enumerated range when > fed with a desired frame rate of 30, while the 4th range would be more > appropriate. [1] https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android/java/src/org/chromium/media/VideoCapture.java&sq=package:chromium&type=cs&q=videocapture.java&l=130 TBR=qinmin@chromium.org BUG=418911 Committed: https://crrev.com/9f73252eb27914b282df24c60549f0581cf0645d Cr-Commit-Position: refs/heads/master@{#297414}

Patch Set 1 #

Total comments: 2

Patch Set 2 : perkj@ nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCapture.java View 1 2 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mcasas
perkj@ brush off your Java, PTAL :)
6 years, 2 months ago (2014-09-30 10:10:15 UTC) #2
perkj_chrome
lgtm https://codereview.chromium.org/614003002/diff/1/media/base/android/java/src/org/chromium/media/VideoCapture.java File media/base/android/java/src/org/chromium/media/VideoCapture.java (right): https://codereview.chromium.org/614003002/diff/1/media/base/android/java/src/org/chromium/media/VideoCapture.java#newcode125 media/base/android/java/src/org/chromium/media/VideoCapture.java:125: int frameRateInMs = frameRate * 1000; nit: a ...
6 years, 2 months ago (2014-09-30 11:18:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614003002/20001
6 years, 2 months ago (2014-09-30 12:32:54 UTC) #5
mcasas
https://codereview.chromium.org/614003002/diff/1/media/base/android/java/src/org/chromium/media/VideoCapture.java File media/base/android/java/src/org/chromium/media/VideoCapture.java (right): https://codereview.chromium.org/614003002/diff/1/media/base/android/java/src/org/chromium/media/VideoCapture.java#newcode125 media/base/android/java/src/org/chromium/media/VideoCapture.java:125: int frameRateInMs = frameRate * 1000; On 2014/09/30 11:18:06, ...
6 years, 2 months ago (2014-09-30 12:33:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14411)
6 years, 2 months ago (2014-09-30 12:39:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614003002/20001
6 years, 2 months ago (2014-09-30 12:56:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6d186a1eecac08eff58a0533f2e9d9e8877554b8
6 years, 2 months ago (2014-09-30 13:25:07 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 13:25:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f73252eb27914b282df24c60549f0581cf0645d
Cr-Commit-Position: refs/heads/master@{#297414}

Powered by Google App Engine
This is Rietveld 408576698