Docserver: Enable GitHub content providers.

Docserver: Enable GitHub content providers.

BUG=293678
R=jyasskin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233413

[Jeffrey Yasskin, 2013-11-06 04:00:19]

lgtm

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/content_providers.py (right):

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/content_providers.py:87:
logging.error('"github" must provide a owner and repo')
I think your error should include the name of the content provider, so that it's
clear which lines in the json file we should be fixing. I missed this for the
'chromium' error, but that should include the name too.

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/content_providers.py:89: file_system =
self._github_file_system_provider.Create(
Does github need to provide a chroot too?

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/content_providers_test.py (right):

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/content_providers_test.py:12: from
github_file_system_provider import GithubFileSystemProvider
I don't think you use this.

[not at google - send to devlin, 2013-11-06 23:00:13]

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/content_providers.py (right):

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/content_providers.py:87:
logging.error('"github" must provide a owner and repo')
On 2013/11/06 04:00:19, Jeffrey Yasskin wrote:
> I think your error should include the name of the content provider, so that
it's
> clear which lines in the json file we should be fixing. I missed this for the
> 'chromium' error, but that should include the name too.

Good idea.

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/content_providers.py:89: file_system =
self._github_file_system_provider.Create(
On 2013/11/06 04:00:19, Jeffrey Yasskin wrote:
> Does github need to provide a chroot too?

Not yet, but might as well.

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/content_providers_test.py (right):

https://codereview.chromium.org/61393002/diff/30001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/content_providers_test.py:12: from
github_file_system_provider import GithubFileSystemProvider
On 2013/11/06 04:00:19, Jeffrey Yasskin wrote:
> I don't think you use this.

Done.

[not at google - send to devlin, 2013-11-06 23:17:58]

Committed patchset #4 manually as r233413.